Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net_http instrumentation not following semantic conventions for net.peer.name #998

Closed
blumamir opened this issue Oct 31, 2021 · 2 comments · Fixed by #999
Closed

net_http instrumentation not following semantic conventions for net.peer.name #998

blumamir opened this issue Oct 31, 2021 · 2 comments · Fixed by #999
Labels
bug Something isn't working

Comments

@blumamir
Copy link
Member

Description of the bug
Spans created from net_http instrumentations are started with attribute peer.hostname and peer.port which are not in the specification. They should be changed to net.peer.name and net.peer.port according to the specification

If it's not intentionally, I can submit a PR with a fix
@blumamir blumamir added the bug Something isn't working label Oct 31, 2021
@arielvalentin
Copy link
Contributor

Thanks for finding this. Contributions are always welcome!

@blumamir blumamir mentioned this issue Nov 1, 2021
Merged
@fbogsany
Copy link
Contributor

fbogsany commented Nov 1, 2021

Looks like these were added recently (at least for HTTP instrumentation) in open-telemetry/opentelemetry-specification#1916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@arielvalentin @fbogsany @blumamir