-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename span processor #1656
rename span processor #1656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contrib doesn't require any code changes but mentions the processor in docs in a couple of places so you might want to update that as well. https://github.com/open-telemetry/opentelemetry-python-contrib/search?q=BatchExportSpanProcessor
Actually it also uses SimpleExportSpanProcessor in a couple of tests. https://github.com/open-telemetry/opentelemetry-python-contrib/search?q=SimpleExportSpanProcessor Not sure why it didn't fail a contrib build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am also curious at how this did not break instrumentation tests.
I guess it didn't since the docker-tests failed. Will fix shortly |
Description
Renamed
BatchExportSpanProcessor
toBatchSpanProcessor
andSimpleExportSpanProcessor
toSimpleSpanProcessor
Fixes #1634
Type of change
Please delete options that are not relevant.
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/
oropentelemetry-sdk/
The method interfaces of
opentelemetry-instrumentation/
have changedThe method interfaces of
test/util
have changedScripts in
scripts/
that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.toml
isort.cfg
.flake8
When a new
.github/CODEOWNER
is addedMajor changes to project information, such as in:
README.md
CONTRIBUTING.md
Yes. - Link to PR:
No.
Checklist: