Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming SimpleSpanExportProcessor #1634

Closed
carlosalberto opened this issue Feb 24, 2021 · 0 comments · Fixed by #1656 or open-telemetry/opentelemetry-python-contrib#352
Closed

Consider renaming SimpleSpanExportProcessor #1634

carlosalberto opened this issue Feb 24, 2021 · 0 comments · Fixed by #1656 or open-telemetry/opentelemetry-python-contrib#352
Assignees
@codeboten
Labels
1.0.0rc2 release candidate 2 for tracing GA

Comments

@carlosalberto
Copy link
Contributor

Consider renaming it to SimpleSpanProcessor, as this is the name other implementations use. Likewise for BatchSpanProcessor.

Not a strong feeling though. Up to you ;)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeboten codeboten

Labels
1.0.0rc2 release candidate 2 for tracing GA
Projects
None yet
Milestone
No milestone
3 participants
@codeboten @carlosalberto @lzchen