Develop/conditional server span pyramid #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sanketmehta28
added a commit
to sanketmehta28/opentelemetry-python-contrib
that referenced
this pull request
Jan 19, 2022
|
owais
approved these changes
Jan 19, 2022
...opentelemetry-instrumentation-pyramid/src/opentelemetry/instrumentation/pyramid/callbacks.py
Outdated
Show resolved
Hide resolved
|
|
sanketmehta28
force-pushed
the
develop/conditional_server_span_pyramid
branch
from
c24a480
to
c1ce2d6
Compare
|
* Making span as internal for falcon in presence of a span in current context * Updating changelog * Fixing lint and generate build failures * Resolving comments: Converting snippet to re-usable function * Fixing build failures * Resolving comments: Creating wrapper for start span to make internal/server span * Rerun docker tests * Resolving comments: Refactoring
…etry#870) * Update CHANGELOG.md * Fix Django 1.9 issue preventing use of MIDDLEWARE_CLASSES Co-authored-by: Srikanth Chekuri <[email protected]>
owais
approved these changes
Jan 22, 2022
srikanthccv
reviewed
Jan 23, 2022
instrumentation/opentelemetry-instrumentation-falcon/tests/test_falcon.py
Outdated
Show resolved
Hide resolved
srikanthccv
approved these changes
Jan 24, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will fix the issue of creating a separate span when pyramid application is instrumented along with any other framework like asgi or wsgi. This fix will extract the span from context first it exists and then create a child span which is expected behavior
Fixes #449
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I have added a separate unit test in test_automatic.py for pyramid instrumentation
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.