Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pyramid: Conditionally create SERVER spans #449

Closed
owais opened this issue Apr 15, 2021 · 1 comment · Fixed by #869
Closed

Pyramid: Conditionally create SERVER spans #449

owais opened this issue Apr 15, 2021 · 1 comment · Fixed by #869
Assignees
@sanketmehta28
Labels
feature-request help wanted Extra attention is needed instrumentation

Comments

@owais
Copy link
Contributor

owais commented Apr 15, 2021

Part of #445
@owais owais added feature-request good first issue Good for newcomers help wanted Extra attention is needed instrumentation labels Apr 15, 2021
@owais owais removed the good first issue Good for newcomers label Oct 3, 2021
@sanketmehta28
Copy link
Member

Hi @owais,

Can you please assign this to me?

sanketmehta28 pushed a commit to sanketmehta28/opentelemetry-python-contrib that referenced this issue Jan 17, 2022
code change to resolve the bug open-telemetry#449
76b2278
@sanketmehta28 sanketmehta28 mentioned this issue Jan 17, 2022
Closed
4 tasks
sanketmehta28 added a commit to sanketmehta28/opentelemetry-python-contrib that referenced this issue Jan 19, 2022
@sanketmehta28
Revert "code change to resolve the bug open-telemetry#449"
76386a8 
This reverts commit 76b2278.
sanketmehta28 added a commit to sanketmehta28/opentelemetry-python-contrib that referenced this issue Jan 19, 2022
@sanketmehta28
code change to resolve the bug open-telemetry#449
eb8ecae
@sanketmehta28 sanketmehta28 mentioned this issue Jan 19, 2022
Merged
6 tasks
sanketmehta28 added a commit to sanketmehta28/opentelemetry-python-contrib that referenced this issue Jan 21, 2022
@sanketmehta28
code change to resolve the bug open-telemetry#449
334e014
owais added a commit that referenced this issue Jan 25, 2022
@sanketmehta28 @ashu658
@pezzer55 @srikanthccv @owais
Develop/conditional server span pyramid (#869)
b32be74 
* code change to resolve the bug #449

* modifying the changelog file to add entry for PR #869

* removing redundent get statement

* Conditionally create server spans for falcon (#867)

* Making span as internal for falcon in presence of a span in current context

* Updating changelog

* Fixing lint and generate build failures

* Resolving comments: Converting snippet to re-usable function

* Fixing build failures

* Resolving comments: Creating wrapper for start span to make internal/server span

* Rerun docker tests

* Resolving comments: Refactoring

* Fix Django 1.9 issue preventing use of MIDDLEWARE_CLASSES (#870)

* Update CHANGELOG.md

* Fix Django 1.9 issue preventing use of MIDDLEWARE_CLASSES

Co-authored-by: Srikanth Chekuri <[email protected]>

* changing the import trace statement to resolve issue with unit test cases

Co-authored-by: Ashutosh Goel <[email protected]>
Co-authored-by: Dan <[email protected]>
Co-authored-by: Srikanth Chekuri <[email protected]>
Co-authored-by: Owais Lone <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sanketmehta28 sanketmehta28

Labels
feature-request help wanted Extra attention is needed instrumentation
Projects
None yet
Milestone
No milestone
2 participants
@owais @sanketmehta28