-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DataDog trace exporter #400
Conversation
`ddtrace` package introduced some breaking changes that break the DataDog trace exporter. This commit downgrades the dependency to last know working version to fix the exporter.
@owais thanks for the ping here. Afaik, nothing wrong with keeping things pinned for now like you’ve done, but I’ll sync with @majorgreys this week on how we can address long term in dd-trace-py. Will followup when I have more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit about the changelog, otherwise LGTM!
I think regardless of how ddtrace chooses to handle it, we should get this merged in so we can keep CI working and users unbroken.
CHANGELOG.md
Outdated
@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
## [Unreleased](https://github.com/open-telemetry/opentelemetry-python-contrib/compare/v0.19b0...HEAD) | |||
|
|||
### Changed | |||
- Downgrade DataDog exporter's `ddtrace` dependency so the exporter continues to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be more accurate to say that the version range has been restricted? We've never prescribed a specific version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Updated.
@ericmustin IMO direct dependencies like this should always specify a fixed version instead of an open range. My recommendation would be to keep the dependency pinned and have the maintainer of opentelemetry-exporter-datadog update it to newer versions as they see fit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Description
Fixed DataDog trace exporter
ddtrace
package introduced some breaking changes that break theDataDog trace exporter. This commit downgrades the dependency to last
know working version to fix the exporter.
Type of change
Please delete options that are not relevant.
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.