Fix DataDog trace exporter #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
requested review from
a team,
toumorokoshi and
hectorhdzg
and removed request for
a team
`ddtrace` package introduced some breaking changes that break the DataDog trace exporter. This commit downgrades the dependency to last know working version to fix the exporter.
|
@owais thanks for the ping here. Afaik, nothing wrong with keeping things pinned for now like you’ve done, but I’ll sync with @majorgreys this week on how we can address long term in dd-trace-py. Will followup when I have more. |
toumorokoshi
suggested changes
Apr 4, 2021
CHANGELOG.md
Outdated
| @@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ## [Unreleased](https://github.com/open-telemetry/opentelemetry-python-contrib/compare/v0.19b0...HEAD) | |||
|
|
|||
| ### Changed | |||
| - Downgrade DataDog exporter's `ddtrace` dependency so the exporter continues to work. | |||
There was a problem hiding this comment.
Would it be more accurate to say that the version range has been restricted? We've never prescribed a specific version.
|
@ericmustin IMO direct dependencies like this should always specify a fixed version instead of an open range. My recommendation would be to keep the dependency pinned and have the maintainer of opentelemetry-exporter-datadog update it to newer versions as they see fit. |
codeboten
approved these changes
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed DataDog trace exporter
ddtracepackage introduced some breaking changes that break theDataDog trace exporter. This commit downgrades the dependency to last
know working version to fix the exporter.
Type of change
Please delete options that are not relevant.
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.