Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for ProxyTracerProvider #399

Merged

Conversation

owais
Copy link
Contributor

@owais owais commented Apr 3, 2021

Description

Updated tests that relied on unset tracer being a noop tracer instead of a proxy tracer.

Includes changes from #400 to make the tests pass.

Fixes #405

Type of change

Please delete options that are not relevant.

  • Fixed broken tests due to change in core repo
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Fixed tests

Does This PR Require a Core Repo Change?

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@owais owais requested review from a team, codeboten and lzchen and removed request for a team April 3, 2021 23:02
@owais owais added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 3, 2021
RequestsInstrumentor().instrument(
tracer_provider=self.original_tracer_provider
tracer_provider=trace._DefaultTracerProvider
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the intention was to ensure that the instrumentation works with noop tracers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is trace.__DefaultTracerProvider?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also should probably remove original_tracer_provider from TestBase

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not directly used but I think might still be useful as it remembers the registered provider before a test case runs and automatically restores it back after a test case finishes running.

@owais owais force-pushed the update-tests-to-account-for-proxy-tracer branch from 255488d to b44af68 Compare April 3, 2021 23:29
@owais owais force-pushed the update-tests-to-account-for-proxy-tracer branch 2 times, most recently from 791da6b to 1064da4 Compare April 5, 2021 18:09
Updated tests that relied on unset tracer being a noop tracer instead of a proxy tracer
@owais owais force-pushed the update-tests-to-account-for-proxy-tracer branch from 1064da4 to e51cce2 Compare April 5, 2021 18:20
@lzchen lzchen merged commit ca8eac6 into open-telemetry:main Apr 7, 2021
@owais owais deleted the update-tests-to-account-for-proxy-tracer branch April 7, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[redis] Unable to initiate tracer
2 participants