Account for ProxyTracerProvider #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
requested review from
a team,
codeboten and
lzchen
and removed request for
a team
owais
commented
Apr 3, 2021
| RequestsInstrumentor().instrument( | ||
| tracer_provider=self.original_tracer_provider | ||
| tracer_provider=trace._DefaultTracerProvider |
There was a problem hiding this comment.
Looks like the intention was to ensure that the instrumentation works with noop tracers.
There was a problem hiding this comment.
Where is trace.__DefaultTracerProvider?
There was a problem hiding this comment.
Also should probably remove original_tracer_provider from TestBase
There was a problem hiding this comment.
It is not directly used but I think might still be useful as it remembers the registered provider before a test case runs and automatically restores it back after a test case finishes running.
owais
force-pushed
the
update-tests-to-account-for-proxy-tracer
branch
from
255488d
to
b44af68
Compare
12 tasks
owais
force-pushed
the
update-tests-to-account-for-proxy-tracer
branch
2 times, most recently
from
791da6b
to
1064da4
Compare
Updated tests that relied on unset tracer being a noop tracer instead of a proxy tracer
owais
force-pushed
the
update-tests-to-account-for-proxy-tracer
branch
from
1064da4
to
e51cce2
Compare
lzchen
approved these changes
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated tests that relied on unset tracer being a noop tracer instead of a proxy tracer.
Includes changes from #400 to make the tests pass.
Fixes #405
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.