Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error handling to opentelemetry-bootstrap -a #2517

Merged
merged 4 commits into from
May 14, 2024
Merged

Add error handling to opentelemetry-bootstrap -a #2517

merged 4 commits into from
May 14, 2024

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented May 10, 2024

Fixes #2516

@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 10, 2024
@ocelotl ocelotl self-assigned this May 10, 2024
@ocelotl ocelotl requested a review from a team May 10, 2024 23:34
@xrmx
Copy link
Contributor

xrmx commented May 13, 2024

Isn't this reintroducing #2053 though?

lzchen
lzchen approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one clarifying question.

@lzchen
Copy link
Contributor

lzchen commented May 13, 2024

Isn't this reintroducing #2053 though?

@xrmx

I think it is reintroducing the error however we are catching the exception, printing the error and then continuing instead of failing the operation.

tammy-baylis-swi
tammy-baylis-swi approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave this a little smoke test (comment) and lgtm, thank you again @ocelotl

@ocelotl ocelotl merged commit d0500c2 into open-telemetry:main May 14, 2024
314 checks passed
@ocelotl ocelotl deleted the issue_2516 branch May 14, 2024 20:32
shadchin pushed a commit to shadchin/opentelemetry-python-contrib that referenced this pull request May 29, 2024
@ocelotl @tammy-baylis-swi @shadchin
Add error handling to opentelemetry-bootstrap -a (open-telemetry#2517)
e3939de 
* Revert "Refactor bootstrap generation (open-telemetry#2101)"

This reverts commit 1ee7261.

* Add error handling to opentelemetry-bootstrap -a

Fixes open-telemetry#2516

---------

Co-authored-by: Tammy Baylis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrmx xrmx xrmx approved these changes

@lzchen lzchen lzchen approved these changes

@tammy-baylis-swi tammy-baylis-swi tammy-baylis-swi approved these changes

Assignees

@ocelotl ocelotl

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add error handling for uninstallable packages to opentelemetry-bootstrap -a install
4 participants
@ocelotl @xrmx @lzchen @tammy-baylis-swi