-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor bootstrap generation #2101
Conversation
b1885ea
to
1683b7f
Compare
Just to clarify, in our release process, we change each package to the release version and then we regenerate |
I think we allow users to specify version in bootstrap so probably have to still reflect this in the install. |
I'm not sure if this is exactly a workaround for #2053 since users will still see an error message if the package doesn't exist in Pypi right? I think there isn't really a workaround since there's no way to provide the actual package (the most we can do is not display the error message and just explain on the issues that the package is not available yet). |
Right, reverted to |
Which fails |
This is a workaround because no exception is being raised now, only an error message is now produced for the particular package. |
I think this fixes the bootstrap script issue, but doesn't actually solve the PyPI error you would when trying to install the non-existent release |
Seconding this, and was also mentioned at today's sig meeting. In this PR description I've included an example error if a user with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @ocelotl please remove the "fixes" line in the pr description as this pr doesn't actually fully resolve the original issue.
any update on this? |
This makes the bootstrap script get the package version directly from pypi instead of from our lists of packages. This makes sure that the packages are actually available for the end user to install. Fixes open-telemetry#2053
This reverts commit 1ee7261.
* Revert "Refactor bootstrap generation (#2101)" This reverts commit 1ee7261. * Add error handling to opentelemetry-bootstrap -a Fixes #2516 --------- Co-authored-by: Tammy Baylis <[email protected]>
* Revert "Refactor bootstrap generation (open-telemetry#2101)" This reverts commit 1ee7261. * Add error handling to opentelemetry-bootstrap -a Fixes open-telemetry#2516 --------- Co-authored-by: Tammy Baylis <[email protected]>
This makes the bootstrap script get the package version directly from pypi instead of from our lists of packages. This makes sure that the packages are actually available for the end user to install.
Fixes #2053