-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move instrumentation opentracing shim #109
Closed
NathanielRN
wants to merge
15
commits into
open-telemetry:master
from
NathanielRN:move-instrumentation-opentracing-shim
Closed
Move instrumentation opentracing shim #109
NathanielRN
wants to merge
15
commits into
open-telemetry:master
from
NathanielRN:move-instrumentation-opentracing-shim
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#922) This uses the OpenTelemetry context management mechanism to store a ScopeShim object in order to make active return the same object as the one returned by start_active_span.
…between OpenTelemetry and OpenTracing spans (open-telemetry#924)
Co-authored-by: Yusuke Tsutsumi <[email protected]>
* dropping support for python 3.4
* updating changelogs and version to 0.13b0
…text (open-telemetry#1146) Co-authored-by: Diego Hurtado <[email protected]>
codeboten
suggested changes
Nov 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The OpenTracing bridge must remain in the core repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes for package
instrumentation/opentelemetry-instrumentation-opentracing-shim
.Adds remaining changes needed to get instrumentation packages to tag
v0.15b0
at open-telemetry/opentelemetry-python@725655a of the Core RepoType of change
Please delete options that are not relevant.
How Has This Been Tested?
Tests will be added in a future PR
Checklist:
- [ ] Changelogs have been updated- [ ] Unit tests have been added- [ ] Documentation has been updated