Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move instrumentation opentracing shim #109

Conversation

NathanielRN
Copy link
Contributor

Description

Changes for package instrumentation/opentelemetry-instrumentation-opentracing-shim.

Adds remaining changes needed to get instrumentation packages to tag v0.15b0 at open-telemetry/opentelemetry-python@725655a of the Core Repo

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tests will be added in a future PR

Checklist:

  • Followed the style guidelines of this project
    - [ ] Changelogs have been updated
    - [ ] Unit tests have been added
    - [ ] Documentation has been updated

lzchen and others added 15 commits August 4, 2020 19:10
…#922)

This uses the OpenTelemetry context management mechanism to store a
ScopeShim object in order to make active return the same object as the
one returned by start_active_span.
* dropping support for python 3.4
@NathanielRN NathanielRN requested a review from a team November 2, 2020 19:21
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OpenTracing bridge must remain in the core repo.

@NathanielRN NathanielRN closed this Nov 2, 2020
@NathanielRN NathanielRN deleted the move-instrumentation-opentracing-shim branch July 21, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants