Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Close issue #1195, "Invalid type Exchange for attribute value. Expected one of bool, str, bytes, int, float or a sequence of those types" warning when Celery task runs another celery task #1196

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Heatstealer
Copy link

@Heatstealer Heatstealer commented Jul 18, 2022

Description

There are a lot of serialization errors when celery task run another celery task in case when you are using custom Exchange and custom Queue.
Span tags could be only bool, str, bytes, int, float.

Fixes ##1195

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested on the environment where issue had happened.
Added unit test

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@Heatstealer Heatstealer requested a review from a team July 18, 2022 13:57
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 18, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Heatstealer (b230ecd)
  • ✅ login: srikanthccv / name: Srikanth Chekuri (f5b272f)
  • ✅ login: tammy-baylis-swi / name: Tammy Baylis (2c3828e)

Copy link
Contributor

@ocelotl ocelotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! We need at least one test case that proves this fix does its intended purpose.

@ocelotl
Copy link
Contributor

ocelotl commented Jul 18, 2022

Also, please sign the CLA ✌️

@lzchen
Copy link
Contributor

lzchen commented Sep 20, 2022

@Heatstealer
Are you still working on this?

@Heatstealer
Copy link
Author

Hello guys, I'm really sorry for so late response. But I'm working for a young corporate and I'd resend CLA agreement to the lawers. I'm pushing them, but I've to get a permission at first. Please understand, it's 1st time that we're faced with that kind of document.

@srikanthccv
Copy link
Member

@Heatstealer ping, please sign the CLA and add the CHANGELOG entry.

@Heatstealer
Copy link
Author

Added unit test, updated changelogs, added comments for fix.

@poofeg
Copy link

poofeg commented Jul 12, 2023

Thanks for the fix! We need at least one test case that proves this fix does its intended purpose.

@ocelotl
Are all the requirements met?

@srikanthccv srikanthccv requested a review from ocelotl July 13, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants