-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Close issue #1195, "Invalid type Exchange for attribute value. Expected one of bool, str, bytes, int, float or a sequence of those types" warning when Celery task runs another celery task #1196
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! We need at least one test case that proves this fix does its intended purpose.
Also, please sign the CLA ✌️ |
@Heatstealer |
Hello guys, I'm really sorry for so late response. But I'm working for a young corporate and I'd resend CLA agreement to the lawers. I'm pushing them, but I've to get a permission at first. Please understand, it's 1st time that we're faced with that kind of document. |
@Heatstealer ping, please sign the CLA and add the CHANGELOG entry. |
Added unit test, updated changelogs, added comments for fix. |
@ocelotl |
Description
There are a lot of serialization errors when celery task run another celery task in case when you are using custom Exchange and custom Queue.
Span tags could be only
bool, str, bytes, int, float
.Fixes ##1195
Type of change
How Has This Been Tested?
Tested on the environment where issue had happened.
Added unit test
Does This PR Require a Core Repo Change?
Checklist: