Skip to content

profiles: improve attribute encoding in ProfilesDictionary #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tigrannajaryan merged 5 commits into from
Aug 21, 2025
Merged

profiles: improve attribute encoding in ProfilesDictionary #672

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
69ad563
profiles dictionary table encoding consistency improvement.
jhalliday Jun 13, 2025
238863f
Revert "profiles dictionary table encoding consistency improvement."
jhalliday Jul 25, 2025
08f7903
profiles: improve attribute encoding in ProfilesDictionary
jhalliday Jul 25, 2025
127d1cb
profiles: improve attribute encoding in ProfilesDictionary
jhalliday Jul 28, 2025
8b0c02b
Merge branch 'main' into profiles-p
jhalliday Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions opentelemetry/proto/profiles/v1development/profiles.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,7 @@ message ProfilesDictionary {
repeated string string_table = 5;

// A common table for attributes referenced by various messages.
repeated opentelemetry.proto.common.v1.KeyValue attribute_table = 6;

// Represents a mapping between Attribute Keys and Units.
repeated AttributeUnit attribute_units = 7;
Comment thread
jhalliday marked this conversation as resolved.
repeated KeyValueAndUnit attribute_table = 6;
Comment thread
jhalliday marked this conversation as resolved.
Comment thread
tigrannajaryan marked this conversation as resolved.
}

// ProfilesData represents the profiles data that can be stored in persistent storage,
Expand Down Expand Up @@ -502,3 +499,12 @@ message Function {
// Line number in source file. 0 means unset.
int64 start_line = 4;
}

// A custom 'dictionary native' style of encoding attributes which is more specialized
// for our use than opentelemetry.proto.common.v1.KeyValue
Comment thread
jhalliday marked this conversation as resolved.
Outdated
// Specifically, uses the string table for keys and allows optional unit information.
message KeyValueAndUnit {
int32 key_strindex = 1;
opentelemetry.proto.common.v1.AnyValue value = 2;
int32 unit_strindex = 3; // non-zero where the unit cannot be derived from the name by semconv.
Comment thread
jhalliday marked this conversation as resolved.
Outdated
}
Comment thread
jhalliday marked this conversation as resolved.
Outdated