profiles: improve attribute encoding in ProfilesDictionary#672
Merged
tigrannajaryan merged 5 commits intoopen-telemetry:mainfrom Aug 21, 2025
Merged
profiles: improve attribute encoding in ProfilesDictionary#672tigrannajaryan merged 5 commits intoopen-telemetry:mainfrom
tigrannajaryan merged 5 commits intoopen-telemetry:mainfrom
Conversation
Contributor
Author
|
ref #659 (comment) |
christos68k
reviewed
Jun 13, 2025
Moved dictionary indexing to a separate PR. This reverts commit 7b243ab.
Contributor
Author
|
@open-telemetry/profiling-maintainers as discussed in the SIG meeting, this PR now has the KeyValueAndUnit change and is ready for another review. The indexing change has moved to #688 |
jhalliday
changed the title
rockdaboot
approved these changes
Jul 25, 2025
Contributor
rockdaboot
left a comment
rockdaboot
left a comment
There was a problem hiding this comment.
lgtm, just a few nits
florianl
approved these changes
Jul 25, 2025
Member
florianl
left a comment
florianl
left a comment
There was a problem hiding this comment.
From a Profiling protocol perspective I appreciate this change. It drops the complexity of needing to handle two tables (attribute_table and attribute_units), while at the same time it also makes benefit of the string table (using key_strindex and unit_strindex).
As the OTel ecosystem uses opentelemetry.proto.common.v1.KeyValue in various signal, we might need to adapt some parts of this ecosystem. But I think, this should not be a blocker for this great step forward!
christos68k
reviewed
Jul 25, 2025
Contributor
Author
|
@jsuereth @tigrannajaryan I've updated it to address @open-telemetry/profiling-maintainers comments. Unless you have anything else I think this one is ready to go. |
christos68k
approved these changes
Jul 28, 2025
Member
|
Please resolve the conflicts. |
Merged
tigrannajaryan
pushed a commit
that referenced
this pull request
Sep 2, 2025
### Changed - profiles: drop gzip requirement. [#661](#661) - profiles: avoid `optional` keyword usage. [#659](#659) - profiles: make `profile_id` optional. [#665](#665) - profiles: use single `Profile.sample_type` and clarify use of timestamps. [#649](#649) - all: add notes about the attribute values restrictions. [#683](https://github.com/open-telemetry/opentelemetry-proto/pull/683)<br>⚠️ **IMPORTANT**: These restrictions can be dropped in a future minor release. - profiles: clarify usage of the zero value as the first element of tables in `ProfilesDictionary`. [#688](#688), [#698](#698) - profiles: unsigned `time_nanos` and `duration_nanos` in `Profile`. [#692](#692) - profiles: improve attribute encoding in `ProfilesDictionary`. [#672](#672) - profiles: simplify profile stack trace representation. [#708](#708) ### Fixed - examples: fix OTLP JSON Event example body. [#666](#666) - docs: minor specification fixes around `UNAVAILABLE` and `RetryInfo`. [#669](#669) ### Removed - profiles: remove `default_sample_type`. [#679](#679) - profiles: remove `has_*` debug info fields, they are moving to attributes. [#595](#595) - profiles: remove `Location.is_folded`. [#690](#690)
fandreuz
added a commit
to fandreuz/async-profiler
that referenced
this pull request
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subsequent to #659 (profiles: avoid 'optional' keyword usage) and in accordance with discussions in the profiling SIG, this PR updates the dictionary message docs to impose a more consistent handling of 'null pointer' semantics in the encoding pattern.