-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init sdk bundle profiler #74
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
============================================
+ Coverage 88.81% 89.58% +0.77%
- Complexity 257 283 +26
============================================
Files 28 31 +3
Lines 733 816 +83
============================================
+ Hits 651 731 +80
- Misses 82 85 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
c67a23f
to
56af9ec
Compare
b09e672
to
9ef2b76
Compare
Hi @jdalmas sorry it's taken so long to get to this PR. We've short on symfony expertise at the moment, but I'll review as best I can. |
We have |
src/Symfony/OtelSdkBundle/DependencyInjection/OtelSdkExtension.php
Outdated
Show resolved
Hide resolved
tests/Unit/Symfony/OtelSdkBundle/DataCollector/OtelDataCollectorTest.php
Show resolved
Hide resolved
a4ee880
to
104912e
Compare
1167655
to
6d024fc
Compare
Related to open-telemetry/opentelemetry-php#567
This PR aim to initialize & scaffold OTEL Bundle Profiler data collector.
Related issue recommands to create a DebugBundle. I don't know if it make sense or if this PR (who let profiling & debug things in OtelSdkBundle) is good enough.
Full Profiler view looks like :
Bottom Profiler view looks like :