Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init sdk bundle profiler #74

Merged
merged 5 commits into from
Oct 16, 2022
Merged

Conversation

jdalmas
Copy link
Contributor

@jdalmas jdalmas commented Jul 31, 2022

Related to open-telemetry/opentelemetry-php#567

This PR aim to initialize & scaffold OTEL Bundle Profiler data collector.

Related issue recommands to create a DebugBundle. I don't know if it make sense or if this PR (who let profiling & debug things in OtelSdkBundle) is good enough.

Full Profiler view looks like :
image

Bottom Profiler view looks like :
image

@codecov
Copy link

codecov bot commented Jul 31, 2022

Codecov Report

Merging #74 (6d024fc) into main (6992bd8) will increase coverage by 0.77%.
The diff coverage is 96.38%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #74      +/-   ##
============================================
+ Coverage     88.81%   89.58%   +0.77%     
- Complexity      257      283      +26     
============================================
  Files            28       31       +3     
  Lines           733      816      +83     
============================================
+ Hits            651      731      +80     
- Misses           82       85       +3     
Flag Coverage Δ
7.4 89.58% <96.38%> (+0.77%) ⬆️
8.0 89.33% <96.38%> (+0.79%) ⬆️
8.1 89.33% <96.38%> (+0.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../OtelSdkBundle/DataCollector/OtelDataCollector.php 94.54% <94.54%> (ø)
...ony/OtelSdkBundle/Debug/TraceableSpanProcessor.php 100.00% <100.00%> (ø)
...ny/OtelSdkBundle/Debug/TraceableTracerProvider.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6992bd8...6d024fc. Read the comment docs.

@jdalmas jdalmas force-pushed the init-bundle-profiler branch from c67a23f to 56af9ec Compare July 31, 2022 16:12
@jdalmas jdalmas marked this pull request as ready for review August 17, 2022 09:22
@jdalmas jdalmas force-pushed the init-bundle-profiler branch 2 times, most recently from b09e672 to 9ef2b76 Compare August 17, 2022 09:57
@brettmc
Copy link
Collaborator

brettmc commented Sep 8, 2022

Hi @jdalmas sorry it's taken so long to get to this PR. We've short on symfony expertise at the moment, but I'll review as best I can.

@brettmc
Copy link
Collaborator

brettmc commented Sep 8, 2022

We have OpenTelemetry\API\Common\Instrumentation\InstrumentationInterface and InstrumentationTrait which I believe is meant to be implemented by 3rd party instrumentations like this one. Can you take a look at it and see if you think it can be incorporated? Some of the methods in OtelDataCollector look the same...

@jdalmas jdalmas force-pushed the init-bundle-profiler branch from a4ee880 to 104912e Compare October 14, 2022 13:13
@jdalmas jdalmas requested a review from a team October 14, 2022 13:13
@jdalmas jdalmas force-pushed the init-bundle-profiler branch from 1167655 to 6d024fc Compare October 14, 2022 13:20
@brettmc brettmc merged commit eac71da into open-telemetry:main Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants