Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opentelemetry-php-contrib] Create Symfony DebugBundle #567

Closed
tidal opened this issue Dec 13, 2021 · 4 comments
Closed

[opentelemetry-php-contrib] Create Symfony DebugBundle #567

tidal opened this issue Dec 13, 2021 · 4 comments
Labels
dev-mode For when we want to make #dev-mode a thing enhancement New feature or request help wanted This issue is looking for someone to work on it large large sized task nice-to-have a nice to have thing! opentelemetry-php-contrib This issue is related to the opentelemetry-php-contrib repository

Comments

@tidal
Copy link
Member

tidal commented Dec 13, 2021

The DebugBundle should enhance the Symfony Profiler with a view of
telemetry data collected by opentelemetry-php. Custom data-collectors and profiler templates need to be created for this to work.
@bobstrecansky bobstrecansky changed the title Create Symfony DebugBundle [opentelemetry-php-contrib] Create Symfony DebugBundle Feb 2, 2022
@bobstrecansky bobstrecansky transferred this issue from open-telemetry/opentelemetry-php-contrib Feb 2, 2022
@tidal tidal added dev-mode For when we want to make #dev-mode a thing enhancement New feature or request large large sized task opentelemetry-php-contrib This issue is related to the opentelemetry-php-contrib repository labels Feb 3, 2022
@stale
Copy link

stale bot commented Mar 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale This issue didn't have recent activity label Mar 10, 2022
@tidal tidal added help wanted This issue is looking for someone to work on it and removed stale This issue didn't have recent activity labels Mar 10, 2022
@bobstrecansky bobstrecansky added the nice-to-have a nice to have thing! label Jun 7, 2022
@jdalmas jdalmas mentioned this issue Jul 31, 2022
Merged
@jdalmas
Copy link

jdalmas commented Jul 31, 2022

I've try something in this PR open-telemetry/opentelemetry-php-contrib#74 .
Like I say, I've put profiling logic into OtelSdkBundle instead of DebugBundle. I don't know if it's wrong or not.

@bobstrecansky
Copy link
Collaborator

@jdalmas - would you like us to merge this?

@jdalmas
Copy link

jdalmas commented Oct 14, 2022

@jdalmas - would you like us to merge this?

@bobstrecansky I've updated PR to use Instrumentation Interface & Trait. I you think this PR is ok, you can merge it.

@brettmc brettmc closed this as completed Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev-mode For when we want to make #dev-mode a thing enhancement New feature or request help wanted This issue is looking for someone to work on it large large sized task nice-to-have a nice to have thing! opentelemetry-php-contrib This issue is related to the opentelemetry-php-contrib repository
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tidal @bobstrecansky @brettmc @jdalmas