Skip to content

Add a warning message when one created collector needs extra RBAC permissions and the service account doesn't have them #3433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 23, 2024
Merged

Add a warning message when one created collector needs extra RBAC permissions and the service account doesn't have them #3433

merged 7 commits into from
Nov 23, 2024

Conversation

iblancasa
Copy link
Contributor

Israel Blancas added 3 commits November 6, 2024 17:57
Add a warning message when one created collector needs extra RBAC per…
9792173 
…missions and the service account doesn't have them

Signed-off-by: Israel Blancas <[email protected]>
Merge branch 'main' of github.com:open-telemetry/opentelemetry-operat…
24ac77a 
…or into 3432
Fix nil
c3908f1 
Signed-off-by: Israel Blancas <[email protected]>
@iblancasa iblancasa marked this pull request as ready for review November 12, 2024 16:04
@iblancasa iblancasa requested a review from a team as a code owner November 12, 2024 16:04
@iblancasa iblancasa self-assigned this Nov 12, 2024
Israel Blancas added 2 commits November 14, 2024 19:46
swiatekm
swiatekm reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@swiatekm swiatekm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not confident we aren't missing some edge cases here. This PR modifies some core components, but doesn't include any new tests. Maybe we can include some test using envtest to check that the webhook behaves the way we expect?

@iblancasa
Copy link
Contributor Author

I'm not confident we aren't missing some edge cases here. This PR modifies some core components, but doesn't include any new tests. Maybe we can include some test using envtest to check that the webhook behaves the way we expect?

I will check how to do that 👍🏻

swiatekm
swiatekm approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swiatekm swiatekm merged commit bf7cdd1 into open-telemetry:main Nov 23, 2024
38 checks passed
@alexkruc alexkruc mentioned this pull request Dec 5, 2024
Closed
Starefossen pushed a commit to Starefossen/opentelemetry-operator that referenced this pull request Apr 10, 2025
@Starefossen
Add a warning message when one created collector needs extra RBAC per…
261626b 
…missions and the service account doesn't have them (open-telemetry#3433)

* Add a warning message when one created collector needs extra RBAC permissions and the service account doesn't have them

Signed-off-by: Israel Blancas <[email protected]>

* Fix nil

Signed-off-by: Israel Blancas <[email protected]>

* Show an admission warning

Signed-off-by: Israel Blancas <[email protected]>

* Apply changes requested in code review

Signed-off-by: Israel Blancas <[email protected]>

---------

Signed-off-by: Israel Blancas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaronoff97 jaronoff97 jaronoff97 approved these changes

@swiatekm swiatekm swiatekm approved these changes

Assignees

@iblancasa iblancasa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show a warning in the webhook if the SA for a collector has not the correct RBAC permissions
3 participants
@iblancasa @jaronoff97 @swiatekm