Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a warning in the webhook if the SA for a collector has not the correct RBAC permissions #3432

Closed
iblancasa opened this issue Nov 6, 2024 · 3 comments · Fixed by #3433
Labels
enhancement New feature or request needs triage

Comments

@iblancasa
Copy link
Contributor

Component(s)

collector

Is your feature request related to a problem? Please describe.

One thing that can happen is that users will not give permission to the operator service account to create RBAC. In that case, users will need to manually create the RBAC for the service account running the collector. If the user is not cautious enough, can create a collector and have failures while running the collector because of the missing permissions.

Describe the solution you'd like

It would be nice to show a warning on the operator logs when the collector is being created.

Describe alternatives you've considered

No response

Additional context

No response

@swiatekm
Copy link
Contributor

Shouldn't we do this in the webhook instead? That would be much more visible to users. I would also add it to the Collector status before operator logs - these are already quite noisy imo.

@iblancasa
Copy link
Contributor Author

Shouldn't we do this in the webhook instead? That would be much more visible to users. I would also add it to the Collector status before operator logs - these are already quite noisy imo.

I'm fine with that. Didn't want to do it in the webhook because I was not sure if it was too much "disruptive"

@swiatekm
Copy link
Contributor

There's some potential for spurious warnings here, but imo it's outweighed by the gain of informing users what RBAC they need proactively.

@iblancasa iblancasa changed the title Show a message in the operator logs if the SA for a collector has not the correct RBAC permissions Show a warning in the webhook if the SA for a collector has not the correct RBAC permissions Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage
Projects
None yet
2 participants