Deprecate label flag and Align label filter flag with attribute filter flag name #3232
Conversation
Signed-off-by: root <[email protected]>
davidhaja
changed the title
| @@ -0,0 +1,16 @@ | |||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | |||
| change_type: enhancement | |||
| component: operator | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: "Depreceate label flag and align label filter flag with attribute filter flag name" |
There was a problem hiding this comment.
please explicitly mention the deprecated flag and the new flag.
There was a problem hiding this comment.
mention when the deprecated flag will be removed and create a ticket for it.
There was a problem hiding this comment.
@pavolloffay Thank you for your review!
Do you know when the deprecated flag will be removed? Is there an exact version or something like that?
Or should I just say it will be removed when the new ticket #XXXXX is resolved?
There was a problem hiding this comment.
i think we can do the latter and just create an issue for remove the deprecated flag after N versions
There was a problem hiding this comment.
Explicitly mentioning the flags
Created new issue #3236 and also mentioning that in the note
There was a problem hiding this comment.
@pavolloffay @jaronoff97
Let me know if I still need to modify something
…y-operator into 3218-align-label-filter-flag
… in changelog and follow-up issue
There was a problem hiding this comment.
@davidhaja one last thing... can you update the e2e workflow to use this?
…y-operator into 3218-align-label-filter-flag
@jaronoff97 |
|
Thank you for your contribution! 🙇 |
Signed-off-by: dhaja [email protected]
Description:
Deprecating label flag and introducing labels-filter flag to align the label filtering flag with attribute filter flag name.
Using the label filters both from label and labels-filter flags, until label flag is removed.
Link to tracking Issue(s): 3218
Testing: N/A
Documentation: N/A