Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align label filter flag with attribute filter flag name #3218

Closed
jaronoff97 opened this issue Aug 13, 2024 · 1 comment · Fixed by #3232
Closed

Align label filter flag with attribute filter flag name #3218

jaronoff97 opened this issue Aug 13, 2024 · 1 comment · Fixed by #3232
Assignees
@davidhaja
Labels
enhancement New feature or request

Comments

@jaronoff97
Copy link
Contributor

Right now the flag we use for label filtering is --label rather than --labels-filter which aligns with the existing naming for the --annotations-filter. To migrate we could introduce the new flag, and automatically move anything from --label to be appended to that. Eventually we deprecate/remove the --label flag.

Originally posted by @jaronoff97 in #3203 (review)
@jaronoff97 jaronoff97 added the enhancement New feature or request label Aug 13, 2024
@davidhaja
Copy link
Contributor

I would like to work on this one.

@davidhaja davidhaja mentioned this issue Aug 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidhaja davidhaja

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@jaronoff97 @davidhaja