Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(B3Propagator): B3 sampled causing gRPC error #977

Merged
merged 3 commits into from
Apr 23, 2020

Conversation

mayurkale22
Copy link
Member

Which problem is this PR solving?

Short description of the changes

@mayurkale22 mayurkale22 added the bug Something isn't working label Apr 22, 2020
@mayurkale22
Copy link
Member Author

/cc @jordanworner would be nice if you can review this change.

@codecov-io
Copy link

codecov-io commented Apr 22, 2020

Codecov Report

Merging #977 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #977   +/-   ##
=======================================
  Coverage   95.02%   95.02%           
=======================================
  Files         209      209           
  Lines        8541     8543    +2     
  Branches      766      768    +2     
=======================================
+ Hits         8116     8118    +2     
  Misses        425      425           
Impacted Files Coverage Δ
...metry-core/src/context/propagation/B3Propagator.ts 97.61% <100.00%> (+0.11%) ⬆️
...entelemetry-core/test/context/B3Propagator.test.ts 100.00% <100.00%> (ø)
.../opentelemetry-core/test/context/composite.test.ts 96.42% <100.00%> (ø)

@mayurkale22 mayurkale22 requested a review from obecny April 23, 2020 18:15
@mayurkale22 mayurkale22 merged commit 73212b8 into open-telemetry:master Apr 23, 2020
@mayurkale22 mayurkale22 deleted the fix_b3_propagator branch April 23, 2020 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plugin-grpc: B3 sampled causing gRPC error
5 participants