Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin-grpc: B3 sampled causing gRPC error #976

Closed
jordanworner opened this issue Apr 22, 2020 · 1 comment · Fixed by #977
Closed

plugin-grpc: B3 sampled causing gRPC error #976

jordanworner opened this issue Apr 22, 2020 · 1 comment · Fixed by #977
Assignees
@mayurkale22
Labels
bug Something isn't working

Comments

@jordanworner
Copy link
Contributor

What version of OpenTelemetry are you using?

0.6.1

What version of Node are you using?

v12.16.2

What did you do?

Calling a gRPC service with sampled using B3Propagator

What did you expect to see?

The sampled value to be added to the gRPC metadata

What did you see instead?

The error:

Error: keys that don't end with '-bin' must have String values

from https://github.com/grpc/grpc-node/blob/grpc%401.24.2/packages/grpc-native-core/src/metadata.js#L74

Additional context

The B3Propagator is setting the sampled value to a Number. The Metadata validate function is expecting a string or a binary value if the key ends in '-bin'.
@jordanworner jordanworner added the bug Something isn't working label Apr 22, 2020
@mayurkale22
Copy link
Member

Thanks for reporting this! I'm working on trying to reproduce this now.

@mayurkale22 mayurkale22 self-assigned this Apr 22, 2020
@mayurkale22 mayurkale22 mentioned this issue Apr 22, 2020
Merged
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@lukiano @rauno56
feat: use Koa router name as span name if available (open-telemetry#976)
fa4fe9c 
* feat: use Koa router name as span name if available

* feat: use Koa router name as span name if available (addressed feedback)

Co-authored-by: Rauno Viskus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mayurkale22 mayurkale22

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(B3Propagator): B3 sampled causing gRPC error mayurkale22/opentelemetry-node
2 participants
@jordanworner @mayurkale22