-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc for node and support for new proto format for node and browser #901
Conversation
Codecov Report
@@ Coverage Diff @@
## master #901 +/- ##
==========================================
- Coverage 94.94% 94.69% -0.26%
==========================================
Files 247 247
Lines 11142 11228 +86
Branches 1065 1077 +12
==========================================
+ Hits 10579 10632 +53
- Misses 563 596 +33
|
@open-telemetry/javascript-approvers Please review when you get a chance. |
Wait with more reviews as I can't make it work with latest otel anyway - will let you know where is the problem when I finish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes so this doesn't get accidentally merged while @obecny is still working on it.
packages/opentelemetry-exporter-collector/src/platform/browser/sendSpans.ts
Show resolved
Hide resolved
packages/opentelemetry-exporter-collector/src/platform/node/util.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added first pass comments.
packages/opentelemetry-core/src/platform/browser/hex-to-bytes.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-exporter-collector/src/platform/browser/sendSpans.ts
Outdated
Show resolved
Hide resolved
@obecny why do you think this one has |
|
I agree with @obecny on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Honestly, PR is very big, easy to miss things. I would like to give another pass before approving.
Which problem is this PR solving?
Short description of the changes
Bear in mind that currently there is no yet opentelemetry collector that supports grpc and new format, this needs to wait until this is doneit is there now, tested and fixed