-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use OTLP format instead of OpenCensus for OTLP exporter #854
Comments
@dyladan assign to you if you're working on this, otherwise will take it. |
I think @obecny is working on this |
When I offered to take this I had forgotten that he already started work. If I'm wrong here, I'm happy to do it. |
Yea I'm almost finished, just trying to have working example ideally with docker (as previously) with |
AFAIK there are premade collector docker images on the omnition dockerhub |
@dyladan already on chat with @mayurkale22 - however cannot make it work yet |
but the quick question as the new proto format so far I have implemented only for node version, for web it stays as it was. Should then this be done for both versions ? |
@tigrannajaryan please confirm if this is the latest docker image with OpenTelemetry receiver support: https://hub.docker.com/r/omnition/opentelemetry-collector-contrib/tags |
grpc support |
Yes, we should update for both. I believe the transformation logic is common for both Node and browser, right? |
We may want to avoid having to deploy grpc with the browser. In that case, we can use the new format but still transport it over http. |
Confirmed. Note that this does not include OTLP receiver/exporter. |
@tigrannajaryan Thanks for the confirmation. May I know the timeline to get a new image with OTLP receiver/exporter support? @obecny I think you should open your PR for reviews, for now we can rely on unit tests and run end to end test once new image is available. WDYT? |
Currently, we use OpenCensus proto based types to export traces from OpenTelemetry instrumentation to the Collector exporter. The goal is to switch to OTLP format/proto (link attached) instead of OpenCensus for OTLP exporter.
Trace Proto: https://github.com/open-telemetry/opentelemetry-proto/blob/master/opentelemetry/proto/trace/v1/trace.proto
Resource Proto: https://github.com/open-telemetry/opentelemetry-proto/blob/master/opentelemetry/proto/resource/v1/resource.proto
The text was updated successfully, but these errors were encountered: