Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OTLP format instead of OpenCensus for OTLP exporter #854

Closed
mayurkale22 opened this issue Mar 12, 2020 · 13 comments · Fixed by #901
Closed

Use OTLP format instead of OpenCensus for OTLP exporter #854

mayurkale22 opened this issue Mar 12, 2020 · 13 comments · Fixed by #901

Comments

@mayurkale22
Copy link
Member

Currently, we use OpenCensus proto based types to export traces from OpenTelemetry instrumentation to the Collector exporter. The goal is to switch to OTLP format/proto (link attached) instead of OpenCensus for OTLP exporter.

Trace Proto: https://github.com/open-telemetry/opentelemetry-proto/blob/master/opentelemetry/proto/trace/v1/trace.proto

Resource Proto: https://github.com/open-telemetry/opentelemetry-proto/blob/master/opentelemetry/proto/resource/v1/resource.proto

@mayurkale22 mayurkale22 added feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers labels Mar 12, 2020
@mayurkale22 mayurkale22 added this to the After Beta Release milestone Mar 18, 2020
@mayurkale22
Copy link
Member Author

@dyladan assign to you if you're working on this, otherwise will take it.

@dyladan
Copy link
Member

dyladan commented Mar 23, 2020

I think @obecny is working on this

@dyladan
Copy link
Member

dyladan commented Mar 23, 2020

When I offered to take this I had forgotten that he already started work. If I'm wrong here, I'm happy to do it.

@obecny
Copy link
Member

obecny commented Mar 23, 2020

Yea I'm almost finished, just trying to have working example ideally with docker (as previously) with https://github.com/open-telemetry/opentelemetry-collector

@dyladan
Copy link
Member

dyladan commented Mar 23, 2020

AFAIK there are premade collector docker images on the omnition dockerhub

@obecny
Copy link
Member

obecny commented Mar 23, 2020

@dyladan already on chat with @mayurkale22 - however cannot make it work yet

@mayurkale22 mayurkale22 removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Mar 23, 2020
@obecny
Copy link
Member

obecny commented Mar 23, 2020

but the quick question as the new proto format so far I have implemented only for node version, for web it stays as it was. Should then this be done for both versions ?

@mayurkale22
Copy link
Member Author

@tigrannajaryan please confirm if this is the latest docker image with OpenTelemetry receiver support: https://hub.docker.com/r/omnition/opentelemetry-collector-contrib/tags

@obecny
Copy link
Member

obecny commented Mar 23, 2020

@tigrannajaryan please confirm if this is the latest docker image with OpenTelemetry receiver support: https://hub.docker.com/r/omnition/opentelemetry-collector-contrib/tags

grpc support

@mayurkale22
Copy link
Member Author

mayurkale22 commented Mar 23, 2020

but the quick question as the new proto format so far I have implemented only for node version, for web it stays as it was. Should then this be done for both versions ?

Yes, we should update for both. I believe the transformation logic is common for both Node and browser, right?

@dyladan
Copy link
Member

dyladan commented Mar 23, 2020

We may want to avoid having to deploy grpc with the browser. In that case, we can use the new format but still transport it over http.

@tigrannajaryan
Copy link
Member

@tigrannajaryan please confirm if this is the latest docker image with OpenTelemetry receiver support: https://hub.docker.com/r/omnition/opentelemetry-collector-contrib/tags

Confirmed. Note that this does not include OTLP receiver/exporter.

@mayurkale22
Copy link
Member Author

Confirmed. Note that this does not include OTLP receiver/exporter.

@tigrannajaryan Thanks for the confirmation. May I know the timeline to get a new image with OTLP receiver/exporter support?

@obecny I think you should open your PR for reviews, for now we can rely on unit tests and run end to end test once new image is available. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants