Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions experimental/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ For notes on migrating to 2.x / 0.200.x see [the upgrade guide](doc/upgrade-to-2

* fix(instrumentation-fetch): preserve init overrides when input is a Request object [#6421](https://github.com/open-telemetry/opentelemetry-js/issues/6421) @akandic47
* fix(otlp-exporter-base): limit Node.js HTTP transport response body to 4 MiB [#6552](https://github.com/open-telemetry/opentelemetry-js/pull/6552) @kartikgola
* fix(web-common): add check for possible unsafe json parse [#6589](https://github.com/open-telemetry/opentelemetry-js/pull/6589) @maryliag

### :books: Documentation

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,11 @@ export class LocalStorageSessionStore implements SessionStore {

const sessionData = localStorage.getItem(SESSION_STORAGE_KEY);
if (sessionData) {
return Promise.resolve(JSON.parse(sessionData) as Session);
try {
return Promise.resolve(JSON.parse(sessionData) as Session);
} catch {
return Promise.resolve(null);
}
}
return Promise.resolve(null);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,16 @@ describe('LocalStorageSessionStore', () => {

assert.deepStrictEqual(retrieved, session);
});

it('return null if localStorage is not available', async () => {
sinon.stub(window, 'localStorage').value(undefined);
const retrieved = await store.get();
assert.strictEqual(retrieved, null);
});

it('return null if stored session is invalid', async () => {
getItemStub.returns('invalid-json');
const retrieved = await store.get();
assert.strictEqual(retrieved, null);
});
});
Loading