fix(web-common): add check for possible unsafe json parse#6589
Merged
maryliag merged 4 commits intoopen-telemetry:mainfrom Apr 14, 2026
Merged
fix(web-common): add check for possible unsafe json parse#6589maryliag merged 4 commits intoopen-telemetry:mainfrom
maryliag merged 4 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6589 +/- ##
=======================================
Coverage 95.75% 95.76%
=======================================
Files 375 375
Lines 12725 12727 +2
Branches 3013 3013
=======================================
+ Hits 12185 12188 +3
+ Misses 540 539 -1
🚀 New features to boost your workflow:
|
overbalance
approved these changes
Apr 13, 2026
david-luna
requested changes
Apr 14, 2026
Contributor
david-luna
left a comment
There was a problem hiding this comment.
@maryliag thakns for catching that unwanted scenario. Please remove the it.only so the full test suite runs and it's good to go :)
Contributor
Author
|
@david-luna ooops (now you know how I'm running the new tests hehe) |
david-luna
approved these changes
Apr 14, 2026
maryliag
added a commit
to maryliag/opentelemetry-js
that referenced
this pull request
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
localStoragedata can be tampered with by other scripts on the same origin. Malformed data crashes the call.