chore: enforce consistent type imports#6467
Merged
overbalance merged 5 commits intoopen-telemetry:mainfrom Mar 4, 2026
Merged
Conversation
5 tasks
trentm
reviewed
Mar 3, 2026
Contributor
trentm
left a comment
There was a problem hiding this comment.
One Q.
This looks great though -- from a preliminary look.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6467 +/- ##
=======================================
Coverage 95.70% 95.70%
=======================================
Files 364 364
Lines 11774 11774
Branches 2747 2747
=======================================
Hits 11268 11268
Misses 506 506
🚀 New features to boost your workflow:
|
Contributor
|
Worth changelog entries? I don't have a strong feeling. |
Contributor
Author
|
@trentm Added changelogs to be thorough |
Contributor
|
Note to self: Some discussion/justification for this change is here: #6371 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@typescript-eslint/consistent-type-importsrule toeslint.base.jswithfixStylelevel to enforceimport typesyntax for type-only imports across the repoTest plan
npm run lint:fixpasses