feat(api-logs, sdk-logs)!: add Logger#enabled method#6371
Merged
david-luna merged 27 commits intoopen-telemetry:mainfrom Mar 30, 2026
Merged
feat(api-logs, sdk-logs)!: add Logger#enabled method#6371david-luna merged 27 commits intoopen-telemetry:mainfrom
david-luna merged 27 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6371 +/- ##
==========================================
+ Coverage 95.71% 95.73% +0.01%
==========================================
Files 369 369
Lines 12461 12494 +33
Branches 2945 2956 +11
==========================================
+ Hits 11927 11961 +34
+ Misses 534 533 -1
🚀 New features to boost your workflow:
|
david-luna
changed the title
david-luna
changed the title
david-luna
commented
Feb 5, 2026
pichlermarc
reviewed
Feb 16, 2026
pichlermarc
reviewed
Feb 24, 2026
Member
pichlermarc
left a comment
pichlermarc
left a comment
There was a problem hiding this comment.
thanks for working on this 🙌
A few more comments around the SDK impl.
david-luna
commented
Feb 26, 2026
david-luna
commented
Feb 26, 2026
david-luna
commented
Feb 26, 2026
| await Promise.all(this.processors.map(processor => processor.shutdown())); | ||
| } | ||
|
|
||
| public enabled(options: { |
Contributor
Author
There was a problem hiding this comment.
note for reviewer: IMO it must be implemented here since any of the processors may implement it and need to be called if so
trentm
requested changes
Feb 27, 2026
Contributor
trentm
left a comment
trentm
left a comment
There was a problem hiding this comment.
Just a start at reviewing. I spent way too much time reading specs and other implementations and poking around.
Co-authored-by: Trent Mick <trentm@gmail.com>
Co-authored-by: Trent Mick <trentm@gmail.com>
trentm
reviewed
Feb 28, 2026
Contributor
trentm
left a comment
trentm
left a comment
There was a problem hiding this comment.
Next review. I haven't looked at tests yet.
1 task
Co-authored-by: Trent Mick <trentm@gmail.com>
…try-js into add-logger-enabled
pichlermarc
approved these changes
Mar 18, 2026
Member
pichlermarc
left a comment
pichlermarc
left a comment
There was a problem hiding this comment.
looks good, thank you for tackling this 🙌
Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
trentm
approved these changes
Mar 27, 2026
Contributor
trentm
left a comment
trentm
left a comment
There was a problem hiding this comment.
LGTM, just the changelog nit. Thanks!
| `NodeSDK` from `@opentelemetry/sdk-node` to get automatic environment variable configuration. | ||
| * fix(instrumentation-http)!: do not normalize hyphens to underscores in captured header attribute names if using stable semconv [#6381](https://github.com/open-telemetry/opentelemetry-js/issues/6381) @trentm | ||
| * With the `headersToSpanAttributes` option, one can specify that HTTP headers should be captured as span attributes named `http.{request,response}.header.HEADERNAME`. With old Semantic Conventions, the `HEADERNAME` normalizes hyphens to underscores, e.g. `http.response.header.content_length`. When stable HTTP semconv is enabled (via `OTEL_SEMCONV_STABILITY_OPT_IN`), hyphens are no longer changed, e.g. `http.response.header.content-length`. | ||
| * feat(api-logs, sdk-logs)!: add `enabled` method to Logger interface and implement it in logs API and SDK [#6371](https://github.com/open-telemetry/opentelemetry-js/pull/6371) @david-luna |
Contributor
There was a problem hiding this comment.
We've done a release since, so this needs to be moved up to the top section.
Contributor
Author
|
@open-telemetry/browser-maintainers could you please check if all is fine? |
joaquin-diaz
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Closes #6351
Added as a breaking change since anyone implementing this interface now must to implement the new method.
Short description of the changes
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: