Skip to content

refactor(api): refactor to avoid circular deps, add dpdm to lint step#6441

Merged
pichlermarc merged 2 commits intoopen-telemetry:mainfrom
dynatrace-oss-contrib:fix/api-circular-deps
Feb 24, 2026
Merged

refactor(api): refactor to avoid circular deps, add dpdm to lint step#6441
pichlermarc merged 2 commits intoopen-telemetry:mainfrom
dynatrace-oss-contrib:fix/api-circular-deps

Conversation

@pichlermarc
Copy link
Copy Markdown
Member

Which problem is this PR solving?

We had not run the dpdm-based cycle-check script for a while. This PR

  • adds it to the lint step to ensure it runs in CI, prevent future regressions
  • resolves existing circular deps in the API package (they were not an issue for end-users as they were types-only cicular deps)
  • updates dpdm to the latest version

Supersedes #6363

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.68%. Comparing base (f9db1a2) to head (243cc05).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6441   +/-   ##
=======================================
  Coverage   95.68%   95.68%           
=======================================
  Files         364      364           
  Lines       11775    11784    +9     
  Branches     2742     2745    +3     
=======================================
+ Hits        11267    11276    +9     
  Misses        508      508           
Files with missing lines Coverage Δ
api/src/metrics/Metric.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pichlermarc pichlermarc force-pushed the fix/api-circular-deps branch from 7088d1f to 34c07e6 Compare February 23, 2026 10:13
@pichlermarc pichlermarc marked this pull request as ready for review February 23, 2026 11:25
@pichlermarc pichlermarc requested review from a team as code owners February 23, 2026 11:25
Comment thread api/src/metrics/Metric.ts Outdated
Comment thread api/src/metrics/Metric.ts Outdated
Copy link
Copy Markdown
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit. THanks for re-instating that lint check.

Comment thread api/src/index.ts Outdated
@pichlermarc pichlermarc added this pull request to the merge queue Feb 24, 2026
Merged via the queue into open-telemetry:main with commit f7cd6ab Feb 24, 2026
27 checks passed
@pichlermarc pichlermarc deleted the fix/api-circular-deps branch February 24, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants