Jaeger no flush interval

[dyladan]

Which problem is this PR solving?

• JaegerExporter can throw on export #608

Short description of the changes

• Remove the interval that periodically flushes the jaeger exporter. The exporter already flushes on every export and should depend on the span processor for batching

[codecov-io]

Codecov Report

Merging #609 into master will decrease coverage by 1.69%.
The diff coverage is 86.84%.

@@            Coverage Diff            @@
##           master     #609     +/-   ##
=========================================
- Coverage   92.13%   90.44%   -1.7%     
=========================================
  Files         182      180      -2     
  Lines        9041     9135     +94     
  Branches      792      814     +22     
=========================================
- Hits         8330     8262     -68     
- Misses        711      873    +162

Impacted Files	Coverage Δ
...ackages/opentelemetry-exporter-jaeger/src/types.ts	100% <ø> (ø)	⬆️
...telemetry-tracing/src/export/BatchSpanProcessor.ts	100% <100%> (ø)	⬆️
.../opentelemetry-exporter-jaeger/test/jaeger.test.ts	100% <100%> (ø)	⬆️
...ckages/opentelemetry-exporter-jaeger/src/jaeger.ts	90% <82.14%> (-2.5%)	⬇️
...pentelemetry-core/test/internal/validators.test.ts	50% <0%> (-50%)	⬇️
...elemetry-core/test/trace/spancontext-utils.test.ts	55.55% <0%> (-44.45%)	⬇️
...lemetry-core/test/trace/ProbabilitySampler.test.ts	56.52% <0%> (-43.48%)	⬇️
...s/opentelemetry-core/test/trace/NoopTracer.test.ts	60% <0%> (-40%)	⬇️
...s/opentelemetry-core/test/context/B3Format.test.ts	63.39% <0%> (-36.61%)	⬇️
...ges/opentelemetry-core/test/trace/NoopSpan.test.ts	63.63% <0%> (-36.37%)	⬇️
... and 33 more

[dyladan]

Explanation of the issue

BatchSpanProcessor has a 20 second default timeout
JaegerExporter has a 5 second default timeout

When the JaegerExporter exports, it calls append on the _sender. In the default configuration, the sender flushes on every append.

After 20 seconds, the BatchSpanProcessor exports a batch of spans, which are appended and then exported. During this export, the 4th 5 second interval of the Jaeger exporter timeout occurs and it attempts to flush. 2 concurrent flushes cause the crash.

Fix: remove the 5 second timer from jaeger exporter

the jaeger exporter is already flushing on every export so there is no need for it to ever flush manually.

Brought over from issue thread

[mayurkale22]

Perhaps flush should happen whenever thriftSpan.length > 0 and move above debug statement in same if loop. WDYT?

[dyladan]

First thing the sender does is check length and return if zero and this isn't a critical path or tight loop. Can change if you feel strongly though

[mayurkale22]

Ok. I was little annoyed by the above debug log, even though nothing was exported it just printed successful append for : 0 every few secs.

[dyladan]

Oh i understand, yea that can be fixed

[dyladan]

755ce9c

[mayurkale22]

overall lgtm

[dyladan]

I also added e7d0695 which makes the batch span processor periodic timer not export if there is nothing to export