File tree 1 file changed +4
-1
lines changed
packages/opentelemetry-exporter-jaeger/src
1 file changed +4
-1
lines changed Original file line number Diff line number Diff line change @@ -52,6 +52,9 @@ export class JaegerExporter implements SpanExporter {
52
52
spans : ReadableSpan [ ] ,
53
53
resultCallback : ( result : ExportResult ) => void
54
54
) : void {
55
+ if ( spans . length === 0 ) {
56
+ return resultCallback ( ExportResult . SUCCESS ) ;
57
+ }
55
58
this . _logger . debug ( 'Jaeger exporter export' ) ;
56
59
this . _sendSpans ( spans , resultCallback ) . catch ( err => {
57
60
this . _logger . error ( `JaegerExporter failed to export: ${ err } ` ) ;
@@ -81,6 +84,7 @@ export class JaegerExporter implements SpanExporter {
81
84
await this . _append ( span ) ;
82
85
} catch ( err ) {
83
86
this . _logger . error ( `failed to append span: ${ err } ` ) ;
87
+ // TODO right now we break out on first error, is that desirable?
84
88
if ( done ) return done ( ExportResult . FAILED_NOT_RETRYABLE ) ;
85
89
}
86
90
}
@@ -98,7 +102,6 @@ export class JaegerExporter implements SpanExporter {
98
102
if ( err ) {
99
103
return reject ( new Error ( err ) ) ;
100
104
}
101
-
102
105
resolve ( count ) ;
103
106
} ) ;
104
107
} ) ;
You can’t perform that action at this time.
0 commit comments