Skip to content

Commit 755ce9c

Browse files
committed
chore: make export noop on empty span array
1 parent 5a14555 commit 755ce9c

File tree

1 file changed

+4
-1
lines changed
  • packages/opentelemetry-exporter-jaeger/src

1 file changed

+4
-1
lines changed

packages/opentelemetry-exporter-jaeger/src/jaeger.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,9 @@ export class JaegerExporter implements SpanExporter {
5252
spans: ReadableSpan[],
5353
resultCallback: (result: ExportResult) => void
5454
): void {
55+
if (spans.length === 0) {
56+
return resultCallback(ExportResult.SUCCESS);
57+
}
5558
this._logger.debug('Jaeger exporter export');
5659
this._sendSpans(spans, resultCallback).catch(err => {
5760
this._logger.error(`JaegerExporter failed to export: ${err}`);
@@ -81,6 +84,7 @@ export class JaegerExporter implements SpanExporter {
8184
await this._append(span);
8285
} catch (err) {
8386
this._logger.error(`failed to append span: ${err}`);
87+
// TODO right now we break out on first error, is that desirable?
8488
if (done) return done(ExportResult.FAILED_NOT_RETRYABLE);
8589
}
8690
}
@@ -98,7 +102,6 @@ export class JaegerExporter implements SpanExporter {
98102
if (err) {
99103
return reject(new Error(err));
100104
}
101-
102105
resolve(count);
103106
});
104107
});

0 commit comments

Comments
 (0)