-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: replace SpanAttributes
, MetricsAttributes
and ResourceAttributes
with Attributes
#4928
refactor!: replace SpanAttributes
, MetricsAttributes
and ResourceAttributes
with Attributes
#4928
Conversation
SpanAttributes
and MetricsAttributes
with Attributes
SpanAttributes
, MetricsAttributes
and ResourceAttributes
with Attributes
SpanAttributes
, MetricsAttributes
and ResourceAttributes
with Attributes
SpanAttributes
, MetricsAttributes
and ResourceAttributes
with Attributes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
The Attribute
type was added 1.3.0
, so we need to update all minimum @opentelemetry/api
versions to at least this 🙂
Done! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #4928 +/- ##
==========================================
- Coverage 92.97% 91.04% -1.93%
==========================================
Files 289 89 -200
Lines 7797 1955 -5842
Branches 1602 416 -1186
==========================================
- Hits 7249 1780 -5469
+ Misses 548 175 -373
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, we actually must not drop the types form the API package, we can just cease to use them in the SDK packages. Only SDK packages will be bumped to 2.0, not the API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whew, this is a doozy. Thanks for all the work on this @david-luna.
Question: Are we sure we want all of these in a single PR? Some things are easier to get done in one shot, but I feel like it might be better to split at least into groups of breaking v nonbreaking, because the nonbreaking ones can happen in main instead of just next.
thanks @JamieDanielson for your feedback I made the assumption the
cc: @pichlermarc, @dyladan |
We will merge
All changes in this PR that target files in The benefit of doing that is this: We periodically have to merge Once we're then ready to release 2.0, we'll merge |
@JamieDanielson @pichlermarc thanks for the feedback. If I understood well I'll split this one in smaller PRs targeting main. If you don't mind I'll try to group changes just to avoid to have too many PRs (one per package). Thanks again |
Which problem is this PR solving?
Closes: #4175
Fixes # (issue)
Short description of the changes
SpanAttributes
,MetricsAttributes
andResourceAttributes
withAttributes
SpanAttibuteValue
andMetricAttributeValue
withAttributeValue
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: