chore(deps): lock file maintenance #4834

renovate-bot · 2024-07-01T01:36:26Z

This PR contains the following updates:

Update	Change
lockFileMaintenance	All locks refreshed

🔧 This Pull Request updates lock files to use the latest dependency versions.

Configuration

📅 Schedule: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

trentm · 2024-07-04T00:41:24Z

The tsc build is failing with errors like these:

Error: node_modules/@types/lodash/common/object.d.ts(1026,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1031,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1041,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1026,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1031,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1041,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1026,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1031,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1041,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1026,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1031,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1041,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1026,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1031,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1041,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1026,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1031,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1041,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1026,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1031,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1041,46): error TS1005: '?' expected.

This is due to the @types/lodash update:

diff -ur node_modules-lodash4.17.5/@types/lodash/package.json node_modules-lodash4.17.6/@types/lodash/package.json
--- node_modules-lodash4.17.5/@types/lodash/package.json	2024-07-03 17:31:16
+++ node_modules-lodash4.17.6/@types/lodash/package.json	2024-07-03 17:30:49
@@ -1,6 +1,6 @@
 {
     "name": "@types/lodash",
-    "version": "4.17.5",
+    "version": "4.17.6",
     "description": "TypeScript definitions for lodash",
     "homepage": "https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/lodash",
     "license": "MIT",
@@ -55,6 +55,6 @@
     },
     "scripts": {},
     "dependencies": {},
-    "typesPublisherContentHash": "74ebed2e7d6c57a170dd86cb86d1848722ce0a78369151c7ac087d43a7a6e2d5",
-    "typeScriptVersion": "4.7"
+    "typesPublisherContentHash": "7b3079d1429e9e75e2d4c67aa9a96e2b37b73f32ccc26b1d4f25bf72d7b27f0f",
+    "typeScriptVersion": "4.8"
 }
...

Here is the problematic "node_modules/@types/lodash/common/object.d.ts" file: https://gist.github.com/trentm/8cab9003b2d2b1641ddc37192c071d0f#file-object-d-ts-L1026

For example it is failing on:

    type GetFieldTypeOfArrayLikeByKey<T extends unknown[], K> =
        K extends number ? T[K]
        : K extends `${infer N extends number}` ? T[N]
//                                           ^--- failing here
        : K extends keyof T ? T[K] : undefined;

Ugh. Does this mean that our being limited to TypeScript 4.4.4 means that we'll start being unable to take some dependencies with too-new .d.ts syntax? I'm guessing the issue is the infer ... extends ... syntax from https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-8.html#improved-inference-for-infer-types-in-template-string-types

pichlermarc · 2024-08-09T11:00:59Z

The tsc build is failing with errors like these:

Error: node_modules/@types/lodash/common/object.d.ts(1026,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1031,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1041,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1026,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1031,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1041,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1026,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1031,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1041,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1026,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1031,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1041,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1026,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1031,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1041,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1026,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1031,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1041,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1026,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1031,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1041,46): error TS1005: '?' expected.

This is due to the @types/lodash update:

diff -ur node_modules-lodash4.17.5/@types/lodash/package.json node_modules-lodash4.17.6/@types/lodash/package.json
--- node_modules-lodash4.17.5/@types/lodash/package.json	2024-07-03 17:31:16
+++ node_modules-lodash4.17.6/@types/lodash/package.json	2024-07-03 17:30:49
@@ -1,6 +1,6 @@
 {
     "name": "@types/lodash",
-    "version": "4.17.5",
+    "version": "4.17.6",
     "description": "TypeScript definitions for lodash",
     "homepage": "https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/lodash",
     "license": "MIT",
@@ -55,6 +55,6 @@
     },
     "scripts": {},
     "dependencies": {},
-    "typesPublisherContentHash": "74ebed2e7d6c57a170dd86cb86d1848722ce0a78369151c7ac087d43a7a6e2d5",
-    "typeScriptVersion": "4.7"
+    "typesPublisherContentHash": "7b3079d1429e9e75e2d4c67aa9a96e2b37b73f32ccc26b1d4f25bf72d7b27f0f",
+    "typeScriptVersion": "4.8"
 }
...

Here is the problematic "node_modules/@types/lodash/common/object.d.ts" file: https://gist.github.com/trentm/8cab9003b2d2b1641ddc37192c071d0f#file-object-d-ts-L1026

For example it is failing on:

    type GetFieldTypeOfArrayLikeByKey<T extends unknown[], K> =
        K extends number ? T[K]
        : K extends `${infer N extends number}` ? T[N]
//                                           ^--- failing here
        : K extends keyof T ? T[K] : undefined;

Ugh. Does this mean that our being limited to TypeScript 4.4.4 means that we'll start being unable to take some dependencies with too-new .d.ts syntax? I'm guessing the issue is the infer ... extends ... syntax from https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-8.html#improved-inference-for-infer-types-in-template-string-types

Yes - as discussed offline while talking about SDK 2.0 it's going to be a real problem moving forward. Fortunately here we can remove this dependency as it was actually unused, see #4905

trentm · 2024-08-09T21:50:54Z

I tried to initiate a rebase/retry of this PR now that #4905 is merged.
I believe https://developer.mend.io/github/open-telemetry/opentelemetry-js/-/job/1a2553f6-269f-47a2-ae67-248a7d571244 was the job, but I don't see any update on this PR. Hrm.

pichlermarc · 2024-08-12T07:41:08Z

I tried to initiate a rebase/retry of this PR now that #4905 is merged. I believe https://developer.mend.io/github/open-telemetry/opentelemetry-js/-/job/1a2553f6-269f-47a2-ae67-248a7d571244 was the job, but I don't see any update on this PR. Hrm.

Hmm, yes it does not seem to update for some reason. I'll try to close this and have it re-open a new one.

renovate-bot requested a review from a team July 1, 2024 01:36

forking-renovate bot added the dependencies Pull requests that update a dependency file label Jul 1, 2024

forking-renovate bot assigned blumamir, dyladan, legendecas and pichlermarc Jul 1, 2024

pichlermarc approved these changes Jul 1, 2024

View reviewed changes

chore(deps): lock file maintenance

89eff8a

renovate-bot force-pushed the renovate/lock-file-maintenance branch from 5c8c58c to 89eff8a Compare July 3, 2024 14:56

trentm mentioned this pull request Jul 17, 2024

deps(opentelemetry-instrumentation): Bump shimmer types to 1.2.0 #4865

Merged

7 tasks

dyladan mentioned this pull request Jul 17, 2024

Update Typescript #4870

Open

12 tasks

pichlermarc mentioned this pull request Aug 9, 2024

deps(sdk-metrics): remove unused lodash.merge dependency #4905

Merged

1 task

pichlermarc closed this Aug 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): lock file maintenance #4834

chore(deps): lock file maintenance #4834

renovate-bot commented Jul 1, 2024 •

edited

Loading

trentm commented Jul 4, 2024

pichlermarc commented Aug 9, 2024

trentm commented Aug 9, 2024

pichlermarc commented Aug 12, 2024

chore(deps): lock file maintenance #4834

chore(deps): lock file maintenance #4834

Conversation

renovate-bot commented Jul 1, 2024 • edited Loading

Configuration

trentm commented Jul 4, 2024

pichlermarc commented Aug 9, 2024

trentm commented Aug 9, 2024

pichlermarc commented Aug 12, 2024

renovate-bot commented Jul 1, 2024 •

edited

Loading