-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node 20 to test matrix #4336
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4336 +/- ##
==========================================
- Coverage 92.29% 92.21% -0.09%
==========================================
Files 330 332 +2
Lines 9426 9439 +13
Branches 1999 2000 +1
==========================================
+ Hits 8700 8704 +4
- Misses 726 735 +9
|
@trentm per your question yesterday it seems that the tooling is actually no longer in the way here. Backported fixes from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems that the tooling is actually no longer in the way here
Nice.
experimental/packages/opentelemetry-instrumentation/test/node/InstrumentationBase.test.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-instrumentation/src/platform/node/index.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Do we want to add it to the list of officially supported runtimes (in the readme)? 🤔 |
Adding node 20 to see what fails in the tooling. Lots of our tooling has been updated since last time I tried this.
All changes previously reviewed in #4295