-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: collect additional process attributes #3605
Merged
dyladan
merged 14 commits into
open-telemetry:main
from
mwear:process-detector-improvements
Mar 17, 2023
Merged
feat: collect additional process attributes #3605
dyladan
merged 14 commits into
open-telemetry:main
from
mwear:process-detector-improvements
Mar 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3605 +/- ##
==========================================
- Coverage 94.09% 93.68% -0.41%
==========================================
Files 263 277 +14
Lines 7625 8445 +820
Branches 1608 1753 +145
==========================================
+ Hits 7175 7912 +737
- Misses 450 533 +83
|
MSNev
reviewed
Feb 11, 2023
packages/opentelemetry-resources/src/platform/node/ProcessDetector.ts
Outdated
Show resolved
Hide resolved
This commit introduces a slight change in behavior. Previously the ProcessDectector would validate that it received attributes that it expected, and returned an empty Resource if it didn't. Based on the types, and the implementation of the ProcessDetector, there will always be a valid ProcessResource. Collection of many of the attributes can be done as a best effort without violating the specification.
mwear
force-pushed
the
process-detector-improvements
branch
from
February 15, 2023 03:53
42f74b3
to
eb0a60f
Compare
Rebased to pick up the changes in #3460. |
dyladan
approved these changes
Mar 2, 2023
legendecas
reviewed
Mar 2, 2023
packages/opentelemetry-resources/src/platform/node/ProcessDetectorSync.ts
Outdated
Show resolved
Hide resolved
dyladan
reviewed
Mar 2, 2023
packages/opentelemetry-resources/src/platform/node/ProcessDetectorSync.ts
Outdated
Show resolved
Hide resolved
JacksonWeber
approved these changes
Mar 6, 2023
MSNev
approved these changes
Mar 6, 2023
pichlermarc
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This PR updates the ProcessDetector to collect three additional attributes: process.command_args, process.owner, and process.executable_path. We currently collect process.command_line, which we could technically drop. The spec has this to say about process.command_args vs process.command_line:
We can keep both, or if we want only one, it should be
process.command_args
.This will likely have to be updated when #3460 merges.
Fixes #3604
Short description of the changes
Updates the
ProcessDetector
to collect:process.command_args
process.owner
process.executable_path
Two Additional Changes
ProcessorDetector
implementation. We now export a noopDetector for browser and have moved the operational implementation to be node specific.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Documentation has been updated