Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect Additional Process Attributes #3604

Closed
mwear opened this issue Feb 11, 2023 · 0 comments · Fixed by #3605
Closed

Collect Additional Process Attributes #3604

mwear opened this issue Feb 11, 2023 · 0 comments · Fixed by #3605
Assignees

Comments

@mwear
Copy link
Member

mwear commented Feb 11, 2023

I'd like to collecto additional process attributes that are recommended by the spec. It recommends collecting process.owner. It also has a preference for collecting process.command_args over process.command_line. We currently collect the latter. While making these changes, it would not hurt to collect process.executable.path.

The spec has this to say about process.command_args vs process.command_line:

Between process.command_args and process.command_line, usually process.command_args should be preferred. On Windows and other systems where the native format of process commands is a single string, process.command_line can additionally (or instead) be used.

We can keep both, or if we want only one, it should be process.command_args.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant