-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add semver check to metrics API #3357
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3357 +/- ##
==========================================
- Coverage 93.48% 93.00% -0.48%
==========================================
Files 243 235 -8
Lines 7332 6593 -739
Branches 1512 1320 -192
==========================================
- Hits 6854 6132 -722
+ Misses 478 461 -17
|
dyladan
added
release:required-for-ga
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
api:metrics
Issues and PRs related to the Metrics API
signal:metrics
Issues and PRs related to general metrics signal
pkg:api-metrics
labels
Oct 24, 2022
legendecas
approved these changes
Oct 25, 2022
pichlermarc
approved these changes
Oct 25, 2022
vmarchaud
approved these changes
Oct 26, 2022
blumamir
approved these changes
Oct 26, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api:metrics
Issues and PRs related to the Metrics API
pkg:api-metrics
signal:metrics
Issues and PRs related to general metrics signal
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check is done by the main API. This applies it to the metrics API so that compatible 1.x versions can be used together.