-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release metrics API as 1.0 #3348
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3348 +/- ##
==========================================
- Coverage 93.40% 92.68% -0.73%
==========================================
Files 243 237 -6
Lines 7374 6921 -453
Branches 1527 1443 -84
==========================================
- Hits 6888 6415 -473
- Misses 486 506 +20
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huge thanks to everyone that has been involved in the metrics project for this 🍾
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🎉
Holding for #3357 please take a look at that. If we don't merge that, then the API can't be used with backwards compatible versions like the main API can |
Because of the way lerna links peer dependencies, the big release depends on the API package being released first. This should fix the compilation issue.