-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove window and document dependencies in web packages #2689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2689 +/- ##
=======================================
Coverage 92.52% 92.52%
=======================================
Files 144 144
Lines 5177 5180 +3
Branches 1102 1103 +1
=======================================
+ Hits 4790 4793 +3
Misses 387 387
|
dyladan
reviewed
Dec 23, 2021
experimental/packages/opentelemetry-instrumentation-fetch/src/fetch.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-instrumentation-xml-http-request/src/xhr.ts
Outdated
Show resolved
Hide resolved
dyladan
approved these changes
Dec 23, 2021
vmarchaud
approved these changes
Dec 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fix the dependencies on window and document API in web packages for WebWorker compatibility.
Related: #1575
Short description of the changes
parseURL
with URL constructor and fallback to anchor element if possible.Type of change
How Has This Been Tested?
This should be web main frame compatible and worker tests should be introduced in #2659.
Checklist:
Unit tests have been addedDocumentation has been updated