Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parseUrl from sdk-trace-web does not support relative paths anymore #2884

Closed
pichlermarc opened this issue Apr 4, 2022 · 1 comment · Fixed by #2972
Closed

parseUrl from sdk-trace-web does not support relative paths anymore #2884

pichlermarc opened this issue Apr 4, 2022 · 1 comment · Fixed by #2972
Labels
bug Something isn't working good first issue Good for newcomers up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@pichlermarc
Copy link
Member

The changes from #2689 might have introduced a breaking change to 1.1.0 that causes relative paths to not be parsed anymore.

The current implementation of parseUrl now throws when providing relative paths as parameter as it calls the URL constructor with it. It previously tolerated relative paths. This caused tests for instrumentation-fetch and instrumentation-xml-http-request in #2871 to fail when updating the dependency to sdk-trace-web from 1.0.1 to 1.1.1.

This might also affect others that are upgrading from 1.0.x to 1.1.0/1.1.1
@dyladan dyladan added the bug Something isn't working label Apr 4, 2022
@pichlermarc pichlermarc mentioned this issue Apr 4, 2022
Merged
7 tasks
@dyladan dyladan added up-for-grabs Good for taking. Extra help will be provided by maintainers good first issue Good for newcomers labels Apr 6, 2022
@legendecas
Copy link
Member

I would like this to wait for #2892 so that we can properly test it with instrumentation-fetch or instrumentation-xhr. parseUrl is not used anywhere in sdk-trace-web so it is not so easy to test it well.

@pichlermarc pichlermarc linked a pull request May 16, 2022 that will close this issue
fix(sdk-web): parse url with relative url string #2972
Merged
5 tasks
@pichlermarc pichlermarc mentioned this issue Jun 20, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(sdk-web): parse url with relative url string legendecas/opentelemetry-js
3 participants
@dyladan @legendecas @pichlermarc