-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release proposal v1.0.1 #2609
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2609 +/- ##
==========================================
- Coverage 93.04% 93.00% -0.05%
==========================================
Files 138 138
Lines 5093 5092 -1
Branches 1096 1095 -1
==========================================
- Hits 4739 4736 -3
- Misses 354 356 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, any chance to release experimental packages too ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm I see in description my PR - changes in experimental only which is listed here but not released, why is that ?
this one -> #2584
I believe because we don't release experimental at the same time of core packages ? |
The automated changelog tool isn't smart enough to know the difference between experimental and stable PRs so I had to do my best to remove the experimental ones and just missed one. I'll remove it.
I was thinking about this. What would you think of a single PR which released experimental and stable? Then the changelog generation is a little easier and we don't have to go through the PR process twice for a single release? |
I checked on the other PR but the experimental will not depend on latest core if we do this, that means some experimental pkgs won't have latest bug fixes. I think its better to split them, WDYT ? |
I can update the core deps in this PR. It just means I have to run the release command for core before experimental which I would have had to do anyway so it's no different. |
I updated the other PR. Take a look there. if you still have doubts we can reopen this. |
🚀 (Enhancement)
opentelemetry-semantic-conventions
opentelemetry-core
,opentelemetry-sdk-trace-base
🐛 (Bug Fix)
opentelemetry-exporter-zipkin
📚 (Refine Doc)
opentelemetry-core
🏠 (Internal)
opentelemetry-sdk-trace-base
,opentelemetry-sdk-trace-node
,opentelemetry-sdk-trace-web
opentelemetry-context-async-hooks
,opentelemetry-context-zone-peer-dep
,opentelemetry-core
,opentelemetry-exporter-jaeger
,opentelemetry-exporter-zipkin
,opentelemetry-propagator-b3
,opentelemetry-propagator-jaeger
,opentelemetry-resources
,opentelemetry-sdk-trace-base
,opentelemetry-sdk-trace-node
,opentelemetry-sdk-trace-web
,opentelemetry-shim-opentracing
opentelemetry-core
Committers: 20