-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: expand pull request template with action items #2509
chore: expand pull request template with action items #2509
Conversation
It might make sense to incorporate the hidden/commented messages in this PR somehow? |
Codecov Report
@@ Coverage Diff @@
## main #2509 +/- ##
==========================================
- Coverage 93.06% 93.05% -0.01%
==========================================
Files 132 139 +7
Lines 4856 5172 +316
Branches 1040 1110 +70
==========================================
+ Hits 4519 4813 +294
- Misses 337 359 +22
|
The commented lines only show up to the person who is authoring the PR. They are hidden if the PR author leaves it it when they click submit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, if any, those instructions could be hidden comments, because they don't add much for the reader.
What I've personally found, is that the checklists are useful in only occasionally(which IMHO talks for them - such a simple means for some benefit). I hope people just take those as reminders and nothing to religiously follow. If we really have a strong rule, we should be able to automate enforcing it as "following guidelines" is enforced by the linter.
Co-authored-by: Rauno Viskus <[email protected]>
Which problem is this PR solving?