Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: service.name resource attribute #2290

Merged
merged 8 commits into from
Jun 25, 2021
Merged

fix: service.name resource attribute #2290

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3987ef6
fix: service.name Resource attribute
OmkarKirpan Jun 17, 2021
82ae64d
chore: remove service name option
OmkarKirpan Jun 17, 2021
ef6363d
style: fix lint errors
OmkarKirpan Jun 17, 2021
992190b
Merge branch 'main' into patch-1
OmkarKirpan Jun 17, 2021
7bb3231
Merge branch 'main' into patch-1
OmkarKirpan Jun 22, 2021
9087e7e
Merge branch 'main' into patch-1
dyladan Jun 23, 2021
38c9b24
chore: update all examples
OmkarKirpan Jun 24, 2021
e488608
style: fix lint errors
OmkarKirpan Jun 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions examples/grpc-js/tracer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,23 @@ const { SimpleSpanProcessor } = require('@opentelemetry/tracing');
const { JaegerExporter } = require('@opentelemetry/exporter-jaeger');
const { ZipkinExporter } = require('@opentelemetry/exporter-zipkin');
const { GrpcInstrumentation } = require('@opentelemetry/instrumentation-grpc');
const { ResourceAttributes } = require('@opentelemetry/semantic-conventions');
const { Resource } = require('@opentelemetry/resources');

const EXPORTER = process.env.EXPORTER || '';

module.exports = (serviceName) => {
const provider = new NodeTracerProvider();
const provider = new NodeTracerProvider({
resource: new Resource({
[ResourceAttributes.SERVICE_NAME]: serviceName,
}),
});

let exporter;
if (EXPORTER.toLowerCase().startsWith('z')) {
exporter = new ZipkinExporter({
serviceName,
});
exporter = new ZipkinExporter();
} else {
exporter = new JaegerExporter({
serviceName,
});
exporter = new JaegerExporter();
}

provider.addSpanProcessor(new SimpleSpanProcessor(exporter));
Expand Down