-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: service.name resource attribute #2290
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the 0.20.0 release and the pull request open-telemetry#2227 it seems that serviceName is deprecated and we should use service.name instead. I havn't easily found this information in the changelog, it did require some digging to understand why the service name was now a very long unknown_service:/path/to/node. Documentation says use service.name Resource attribute instead. but it wasn't about replacing serviceName: 'yourServiceName' by service: { name: 'yourServiceName'}.
OmkarKirpan
requested review from
dyladan,
Flarna,
johnbley,
legendecas,
markwolff,
mayurkale22,
MSNev,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
June 17, 2021 10:01
|
removes service name option passed in exporter
vmarchaud
approved these changes
Jun 17, 2021
Codecov Report
@@ Coverage Diff @@
## main #2290 +/- ##
==========================================
+ Coverage 92.28% 92.60% +0.32%
==========================================
Files 128 142 +14
Lines 4210 5057 +847
Branches 857 1038 +181
==========================================
+ Hits 3885 4683 +798
- Misses 325 374 +49
|
dyladan
approved these changes
Jun 23, 2021
MSNev
approved these changes
Jun 23, 2021
obecny
approved these changes
Jun 23, 2021
OmkarKirpan
changed the title
fix: service.name resource attribute for grpc-js example
fix: service.name resource attribute
Jun 24, 2021
Merged
This was referenced Feb 22, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes example code in
opentelemetry-js/examples/
and uses ResourceAttributes from semantic-conventions module to access the standard resource names.Since the 0.20.0 release and the pull request chore: set default service name #2227 it seems that serviceName is deprecated and we should use service.name instead. I havn't easily found this information in the changelog, it did require some digging to understand why the service name was now a very long unknown_service:/path/to/node. Documentation says use service.name Resource attribute instead. but it wasn't about replacing serviceName: 'yourServiceName' by service: { name: 'yourServiceName'}.
Fix for How to use service.name resource attribute since the 0.20.0 release ? How to use service.name resource attribute since the 0.20.0 release ? #2271
Short description of the changes