-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(semantic-conventions): upgrade semantic conventions to version 1… #2268
Conversation
….4.0 spec Ran the generator to generate the semantic and resource atributes based on the v1.4.0 opentelemetry specification.
Codecov Report
@@ Coverage Diff @@
## main #2268 +/- ##
==========================================
- Coverage 92.73% 92.72% -0.02%
==========================================
Files 144 144
Lines 5179 5179
Branches 1060 1060
==========================================
- Hits 4803 4802 -1
- Misses 376 377 +1
|
why some of the resources attributes have double quotes instead of single ? |
Looks like the enums have double quotes and the consts have single quotes. i'm sure it has to do with the template used for generation |
Changing line 19 of
|
I have updated the template and regenerated it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Ran the generator to generate the semantic and resource atributes based
on the v1.4.0 opentelemetry specification.
Which problem is this PR solving?
Short description of the changes