Skip to content

Commit

Permalink
feat(semantic-conventions): upgrade semantic conventions to version 1… (
Browse files Browse the repository at this point in the history
#2268)

* feat(semantic-conventions): upgrade semantic conventions to version 1.4.0 spec

Ran the generator to generate the semantic and resource atributes based
on the v1.4.0 opentelemetry specification.

* fix: ensure the string as single quoted

* style: convert double to single quote

Co-authored-by: Weyert de Boer <[email protected]>
Co-authored-by: Daniel Dyla <[email protected]>
Co-authored-by: Valentin Marchaud <[email protected]>
  • Loading branch information
4 people authored Jun 12, 2021
1 parent 5b6573e commit a3b7738
Show file tree
Hide file tree
Showing 6 changed files with 596 additions and 491 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@ export class AwsBeanstalkDetector implements Detector {
return new Resource({
[ResourceAttributes.CLOUD_PROVIDER]: CloudProviderValues.AWS,
[ResourceAttributes.CLOUD_PLATFORM]:
CloudPlatformValues.AWS_ELASTICBEANSTALK,
CloudPlatformValues.AWS_ELASTIC_BEANSTALK,
[ResourceAttributes.SERVICE_NAME]:
CloudPlatformValues.AWS_ELASTICBEANSTALK,
CloudPlatformValues.AWS_ELASTIC_BEANSTALK,
[ResourceAttributes.SERVICE_NAMESPACE]: parsedData.environment_name,
[ResourceAttributes.SERVICE_VERSION]: parsedData.version_label,
[ResourceAttributes.SERVICE_INSTANCE_ID]: parsedData.deployment_id,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ describe('BeanstalkResourceDetector', () => {
sinon.assert.calledOnce(readStub);
assert.ok(resource);
assertServiceResource(resource, {
name: CloudPlatformValues.AWS_ELASTICBEANSTALK,
name: CloudPlatformValues.AWS_ELASTIC_BEANSTALK,
namespace: 'scorekeep',
version: 'app-5a56-170119_190650-stage-170119_190650',
instanceId: '32',
Expand All @@ -80,7 +80,7 @@ describe('BeanstalkResourceDetector', () => {
sinon.assert.calledOnce(readStub);
assert.ok(resource);
assertServiceResource(resource, {
name: CloudPlatformValues.AWS_ELASTICBEANSTALK,
name: CloudPlatformValues.AWS_ELASTIC_BEANSTALK,
namespace: 'scorekeep',
version: 'app-5a56-170119_190650-stage-170119_190650',
instanceId: '32',
Expand Down
Loading

0 comments on commit a3b7738

Please sign in to comment.