Update nock to v13

[cole-easton]

Which problem is this PR solving?

Update Nock to v13
Fixes #1303

Short description of the changes

Nock version was updated and the deprecated and unstable http.ClientRequest.abort() method was replaced with destroy(), to ensure the behavior of the tests was correct and stable.

[obecny]

what about replacing socketDelay in favour of delayConnection ?

[cole-easton]

@obecny I only saw two occurrences of socketDelay, which I've replaced. If I am missing any, could you point them out? Nothing else shows up in the project search feature of my editor.

[codecov]

Codecov Report

Merging #2249 (8eed30d) into main (fd2410c) will decrease coverage by 0.46%.
The diff coverage is n/a.

❗ Current head 8eed30d differs from pull request most recent head 431c756. Consider uploading reports for the commit 431c756 to get more accurate results

@@            Coverage Diff             @@
##             main    #2249      +/-   ##
==========================================
- Coverage   92.80%   92.34%   -0.47%     
==========================================
  Files         145      128      -17     
  Lines        5226     4244     -982     
  Branches     1071      867     -204     
==========================================
- Hits         4850     3919     -931     
+ Misses        376      325      -51     

Impacted Files	Coverage Δ
...emetry-core/src/platform/node/RandomIdGenerator.ts	87.50% <0.00%> (-6.25%)	⬇️
...ges/opentelemetry-instrumentation-http/src/http.ts	94.88% <0.00%> (-0.10%)	⬇️
...s/opentelemetry-instrumentation-fetch/src/fetch.ts
...ation-xml-http-request/src/enums/AttributeNames.ts
...kages/opentelemetry-web/src/StackContextManager.ts
packages/opentelemetry-web/src/types.ts
...lemetry-exporter-collector/src/transformMetrics.ts
...es/opentelemetry-context-zone-peer-dep/src/util.ts
...ry-context-zone-peer-dep/src/ZoneContextManager.ts
packages/opentelemetry-web/src/utils.ts
... and 9 more

[obecny]

@obecny I only saw two occurrences of socketDelay, which I've replaced. If I am missing any, could you point them out? Nothing else shows up in the project search feature of my editor.

hmm I somehow missed those changes, thought there were more :), thx

[obecny]

lgtm

[dyladan]

This is mergeable but I don't have permission to update the branch

[vmarchaud]

@cole-easton Could you please rebase the branch so we can merge it ? (If possible allow us maintainers to edit your branch so we can it ourselves before merging it)

[dyladan]

I still cannot merge this without permission to update your branch

[cole-easton]

@vmarchaud @dyladan Sorry for the delay. I just rebased -- you should be able to merge now.

[dyladan]

Rerunning tests to see if the browser test failure was a fluke. If not, you will need to fix the test.

[dyladan]

Have you looked into the browser test failures?

[dyladan]

Hundreds of files changed and many things that seem to have already been done? Not sure what's going on but the tests are failing and there is something going on here other than just upgrading nock.

[vmarchaud]

lgtm if tests are green

[dyladan]

LGTM after merge conflicts fix

[dyladan]

@cole-easton can you fix the conflicts so this can be merged?

[dyladan]

@cole-easton bump

[alolita]

Hi @dyladan - can you please re-assign this issue to @rltoSD so that these conflicts can be resolved and the PR can be completed. Thanks!

[vmarchaud]

Hi @dyladan - can you please re-assign this issue to @rltoSD so that these conflicts can be resolved and the PR can be completed. Thanks!

I believe he need to comment on the issue/PR so we can assign it

[dyladan]

@alolita i already did that at #2652

[dyladan]

Closed in favor of #2652