Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused dependency #1822

Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jan 14, 2021

Fixes #1820

This version of axios is triggering security alerts so it is important to merge this soon. The dependency is unused so this should be no problem.

@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #1822 (bfac17d) into master (14931ce) will decrease coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1822      +/-   ##
==========================================
- Coverage   92.49%   92.27%   -0.23%     
==========================================
  Files         173      169       -4     
  Lines        6038     5721     -317     
  Branches     1284     1234      -50     
==========================================
- Hits         5585     5279     -306     
+ Misses        453      442      -11     
Impacted Files Coverage Δ
...-instrumentation-fetch/src/enums/AttributeNames.ts
...mentation-xml-http-request/src/enums/EventNames.ts
...s/opentelemetry-instrumentation-fetch/src/fetch.ts
...emetry-instrumentation-xml-http-request/src/xhr.ts

@dyladan dyladan merged commit 3334230 into open-telemetry:master Jan 14, 2021
@dyladan dyladan deleted the remove-unused-axios branch January 14, 2021 22:04
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Axios version update
4 participants