feat(host-metrics)!: use the package name as the default instrumentat…

…ion scope name, to align with instrumentations (open-telemetry#1822) Closes: open-telemetry#1782
dynatrace-oss-contrib · Dec 7, 2023 · bcf3501 · bcf3501
1 parent 4782f5b
commit bcf3501
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/packages/opentelemetry-host-metrics/src/BaseMetrics.ts b/packages/opentelemetry-host-metrics/src/BaseMetrics.ts
@@ -33,7 +33,7 @@ export interface MetricsCollectorConfig {
   url?: string;
 }
 
-const DEFAULT_NAME = 'opentelemetry-host-metrics';
+const DEFAULT_NAME = '@opentelemetry/host-metrics';
 
 /**
  * Base Class for metrics

diff --git a/packages/opentelemetry-host-metrics/test/metric.test.ts b/packages/opentelemetry-host-metrics/test/metric.test.ts
@@ -139,8 +139,9 @@ describe('Host Metrics', () => {
 
       hostMetrics = new HostMetrics({
         meterProvider,
-        name: 'opentelemetry-host-metrics',
+        name: '', // to get default instrumentation scope name
       });
+
       await hostMetrics.start();
 
       const dateStub = sandbox
@@ -341,6 +342,11 @@ async function getRecords(
   assert(collectionResult != null);
   assert.strictEqual(collectionResult.resourceMetrics.scopeMetrics.length, 1);
   const scopeMetrics = collectionResult.resourceMetrics.scopeMetrics[0];
+  assert.strictEqual(
+    scopeMetrics.scope.name,
+    '@opentelemetry/host-metrics',
+    'default instrumentation scope name is the package name'
+  );
   const metricDataList = scopeMetrics.metrics.filter(
     metric => metric.descriptor.name === name
   );