-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use http keep-alive in collector exporter #1661
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1661 +/- ##
==========================================
+ Coverage 92.17% 92.18% +0.01%
==========================================
Files 167 167
Lines 5594 5594
Branches 1191 1191
==========================================
+ Hits 5156 5157 +1
+ Misses 438 437 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a couple of questions, but otherwise this looks to be on track. Perhaps others can chime in with opinions.
packages/opentelemetry-exporter-collector/src/platform/node/CollectorExporterNodeBase.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have a test that verify that it correctly re-use connections
packages/opentelemetry-exporter-collector/src/platform/node/util.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-exporter-collector/src/platform/node/CollectorExporterNodeBase.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-exporter-collector/src/platform/node/util.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-exporter-collector/src/platform/node/CollectorExporterNodeBase.ts
Outdated
Show resolved
Hide resolved
I haven't seen any updates since the last round of code reviews. Is this still in progress? |
@dyladan I have made progress on this. I am having a little confusion with platform specific and package wise codebase. I am also looking about adding tests for this. |
packages/opentelemetry-exporter-collector/src/platform/node/CollectorExporterNodeBase.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-exporter-collector/src/platform/node/CollectorExporterNodeBase.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-exporter-collector/src/platform/node/CollectorExporterNodeBase.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-exporter-collector/src/platform/node/CollectorExporterNodeBase.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Bartlomiej Obecny <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls resolve the conflicts so we can merge it, thx
@obecny Resolved. There one test failing in node12 : Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.. I think this is not related to changes from this PR. |
Fixes #1638