Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use http keep-alive for OTLP/HTTP #1638

Closed
mwear opened this issue Oct 28, 2020 · 5 comments · Fixed by #1661
Closed

Use http keep-alive for OTLP/HTTP #1638

mwear opened this issue Oct 28, 2020 · 5 comments · Fixed by #1661
Assignees
Labels
enhancement New feature or request

Comments

@mwear
Copy link
Member

mwear commented Oct 28, 2020

As discussed at the SIG meeting earlier today, we can improve the performance of our collector exporter by reusing http connections with http keep-alive. This strategy would apply to proto over http and json over http export formats.

@mwear mwear added enhancement New feature or request up-for-grabs Good for taking. Extra help will be provided by maintainers labels Oct 28, 2020
@mwear mwear changed the title Use http keep-alive for OTLP/JSON Use http keep-alive for OTLP/HTTP Oct 29, 2020
@srikanthccv
Copy link
Member

Hi @mwear, I would like to work on this.

@vmarchaud vmarchaud removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Nov 6, 2020
@vmarchaud
Copy link
Member

@lonewolf3739 Feel free to ping if you want some help !

@srikanthccv
Copy link
Member

@vmarchaud , Thanks! I have a question regarding the value setting for header. What values should be set for timeout and max in the header. Is there any chance of reading them from env and if not available fallback to some default values?

@vmarchaud
Copy link
Member

I think everything should be configurable from the exporter config (it should be possible to disable keep alive too). For the defaults, i believe nodejs already defaults no ?

@srikanthccv
Copy link
Member

I think everything should be configurable from the exporter config (it should be possible to disable keep alive too)

Yes, makes sense. May we should add some env like CONNECTION_REUSE_ENABLE?

For the defaults, i believe nodejs already defaults no ?

Yes, it does.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants